Page MenuHomePhabricator

danilashtefan (Danil Stefaniuc)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2021, 12:47 PM (6 w, 4 d)

Recent Activity

Fri, Dec 3

danilashtefan accepted D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.
Fri, Dec 3, 2:26 AM · Restricted Project

Fri, Nov 26

danilashtefan added a comment to D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

Hi @labath, Thank you so much for your comment and correction. The initial version of the test was the following, with array of ValueCheck objects:

Fri, Nov 26, 3:37 AM · Restricted Project

Thu, Nov 25

danilashtefan updated the diff for D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

As we discussed offline, I add the print tests, since SBValue.GetValue() doesn't work for complex structures

Thu, Nov 25, 2:23 AM · Restricted Project

Wed, Nov 24

danilashtefan updated the diff for D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

Unified tests added

Wed, Nov 24, 12:43 PM · Restricted Project

Tue, Nov 23

danilashtefan retitled D114433: [formatters] List and forward_list capping_size determination and application from [formatters] Draft PR for the list nad forward_list capping_size to [formatters] List and forward_list capping_size determination and application.
Tue, Nov 23, 1:29 PM · Restricted Project
danilashtefan updated the diff for D114433: [formatters] List and forward_list capping_size determination and application.

Deleted duplicated tests from both platforms

Tue, Nov 23, 1:19 PM · Restricted Project
danilashtefan updated the diff for D114433: [formatters] List and forward_list capping_size determination and application.

List tests unification for libcxx and libstdcpp

Tue, Nov 23, 1:14 PM · Restricted Project
danilashtefan retitled D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters. from Draft PR for the bitset capping size limitation avoidance to [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters..
Tue, Nov 23, 11:05 AM · Restricted Project
danilashtefan updated the summary of D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters..
Tue, Nov 23, 11:03 AM · Restricted Project
danilashtefan requested review of D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters..
Tue, Nov 23, 11:02 AM · Restricted Project
danilashtefan updated the diff for D114433: [formatters] List and forward_list capping_size determination and application.

Done!

Tue, Nov 23, 10:19 AM · Restricted Project
danilashtefan accepted D114458: Make some libstd++ formatters safer.
Tue, Nov 23, 10:17 AM · Restricted Project
danilashtefan added inline comments to D114433: [formatters] List and forward_list capping_size determination and application.
Tue, Nov 23, 4:46 AM · Restricted Project
danilashtefan added a reviewer for D114433: [formatters] List and forward_list capping_size determination and application: wallace.
Tue, Nov 23, 4:05 AM · Restricted Project
danilashtefan requested review of D114433: [formatters] List and forward_list capping_size determination and application.
Tue, Nov 23, 3:56 AM · Restricted Project

Mon, Nov 22

danilashtefan accepted D114403: [formatters] Add a formatter for libstdc++ optional.
Mon, Nov 22, 3:34 PM · Restricted Project

Sun, Nov 21

danilashtefan updated the diff for D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

Size determined

Sun, Nov 21, 3:05 AM · Restricted Project

Fri, Nov 19

danilashtefan added a reviewer for D114266: [formatters] Draft Optional PR: wallace.
Fri, Nov 19, 10:40 AM · Restricted Project
danilashtefan requested review of D114266: [formatters] Draft Optional PR.
Fri, Nov 19, 10:39 AM · Restricted Project

Wed, Nov 17

danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Done!

Wed, Nov 17, 1:04 PM · Restricted Project
danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

All the above-mentioned is changed. Thank you!

Wed, Nov 17, 12:19 PM · Restricted Project

Tue, Nov 16

danilashtefan added a reviewer for D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one: wallace.
Tue, Nov 16, 9:28 AM · Restricted Project
danilashtefan added a comment to D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

When I mocked the num_children to return 4, formatter works for any structure with size <= 4. here is the example:

Tue, Nov 16, 9:28 AM · Restricted Project
danilashtefan added inline comments to D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.
Tue, Nov 16, 9:24 AM · Restricted Project
danilashtefan requested review of D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.
Tue, Nov 16, 9:11 AM · Restricted Project

Sun, Nov 14

danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Some naming corrections

Sun, Nov 14, 7:31 AM · Restricted Project

Sat, Nov 13

danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Cosmetic change

Sat, Nov 13, 7:30 AM · Restricted Project
danilashtefan added a comment to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Hi Walter,

Sat, Nov 13, 7:23 AM · Restricted Project
danilashtefan retitled D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset from [formatters] Draft diff for unordered_map libstdcpp formatter to [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.
Sat, Nov 13, 7:20 AM · Restricted Project
danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

All the changes are done and tests pass

Sat, Nov 13, 7:18 AM · Restricted Project

Fri, Nov 12

danilashtefan added inline comments to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.
Fri, Nov 12, 6:12 AM · Restricted Project
danilashtefan added a comment to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Hi Walter :) This is the Draft PR for the unordered_map/set data formatter. Currently it works well in case both key and values are of the same primitive data types (except string).

Fri, Nov 12, 6:08 AM · Restricted Project
danilashtefan added a reviewer for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset: wallace.
Fri, Nov 12, 5:35 AM · Restricted Project
danilashtefan updated the diff for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

Small cosmetic change

Fri, Nov 12, 5:34 AM · Restricted Project
danilashtefan retitled D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset from Draft diff for unordered_map libstdcpp formatter to [formatters] Draft diff for unordered_map libstdcpp formatter.
Fri, Nov 12, 5:19 AM · Restricted Project
danilashtefan retitled D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset from next to Draft diff for unordered_map libstdcpp formatter.
Fri, Nov 12, 5:18 AM · Restricted Project
danilashtefan requested review of D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.
Fri, Nov 12, 5:17 AM · Restricted Project

Tue, Nov 9

danilashtefan updated the diff for D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

Right size is returned and tests are unified! :)

Tue, Nov 9, 11:09 AM · Restricted Project
danilashtefan added inline comments to D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.
Tue, Nov 9, 2:18 AM · Restricted Project
danilashtefan updated the diff for D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

All the requested changes are done :)

Tue, Nov 9, 2:14 AM · Restricted Project

Mon, Nov 8

danilashtefan updated the diff for D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

All of the requested changes are done. Please, let me know if any other corrections are needed

Mon, Nov 8, 9:18 AM · Restricted Project

Sun, Nov 7

danilashtefan added a comment to D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

Hi Walter:) Please, could you advise what can I change/do more? As a next step, I will unify the tests across the libcxx and libstdcpp formatters.

Sun, Nov 7, 1:23 AM · Restricted Project
danilashtefan retitled D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter from Summary: to [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.
Sun, Nov 7, 1:22 AM · Restricted Project
danilashtefan requested review of D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.
Sun, Nov 7, 1:13 AM · Restricted Project

Oct 30 2021

danilashtefan updated the diff for D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.

refactoring

Oct 30 2021, 2:46 PM · Restricted Project
danilashtefan updated the diff for D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.

rebased

Oct 30 2021, 2:15 PM · Restricted Project
danilashtefan added a comment to D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.

I thought that you misprinted the name and wanted to call the formatter MapLikeSynth provider. Please, correct me if I am wrong and I will change names accordingly

Oct 30 2021, 7:21 AM · Restricted Project
danilashtefan updated the diff for D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.

All the above specified parts are changed. Thank you!

Oct 30 2021, 7:14 AM · Restricted Project

Oct 29 2021

danilashtefan retitled D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs from [formatters] Add a libstdcpp formatter for multimap. Unify and modify tests across stdlibs to [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.
Oct 29 2021, 2:04 AM · Restricted Project
danilashtefan retitled D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs from [formatters] Add a libstdcpp formatter for multiset. Unify and modify tests across stdlibs to [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.
Oct 29 2021, 2:04 AM · Restricted Project
danilashtefan retitled D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs from Summary: to [formatters] Add a libstdcpp formatter for multiset. Unify and modify tests across stdlibs.
Oct 29 2021, 2:03 AM · Restricted Project
danilashtefan requested review of D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.
Oct 29 2021, 2:00 AM · Restricted Project

Oct 28 2021

danilashtefan updated the summary of D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.
Oct 28 2021, 1:39 PM · Restricted Project
danilashtefan retitled D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs from [formatters] Add a libstdcpp formatter for multimap and unify tests across stdlibs to [formatters] Add a libstdcpp formatter for multimap. Unify and modify tests across stdlibs.
Oct 28 2021, 1:38 PM · Restricted Project
danilashtefan requested review of D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.
Oct 28 2021, 1:36 PM · Restricted Project

Oct 27 2021

danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Last thing corrected :)

Oct 27 2021, 11:38 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Refactoring

Oct 27 2021, 11:21 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Small formatting

Oct 27 2021, 7:26 AM · Restricted Project
danilashtefan added inline comments to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.
Oct 27 2021, 7:24 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Thank you for the comments, I have done everything specified!

Oct 27 2021, 7:17 AM · Restricted Project

Oct 26 2021

danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

Refactoring

Oct 26 2021, 2:21 PM · Restricted Project
danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

Refactoring

Oct 26 2021, 2:09 PM · Restricted Project
danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

With this changes I substitute the verbose long printed check with ValueCheck approach

Oct 26 2021, 1:48 PM · Restricted Project
danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

Fixing

Oct 26 2021, 9:27 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Deleted libcxx tests

Oct 26 2021, 8:38 AM · Restricted Project
danilashtefan retitled D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs from Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference values check). So to make them pass I had to change some stl_summarry_flags... to Set synthetic children.
Oct 26 2021, 8:16 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Set synthetic child

Oct 26 2021, 8:13 AM · Restricted Project
danilashtefan updated the diff for D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Set synthetic children

Oct 26 2021, 8:06 AM · Restricted Project
danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

Minor corrections

Oct 26 2021, 8:00 AM · Restricted Project
danilashtefan requested review of D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.
Oct 26 2021, 7:27 AM · Restricted Project

Oct 25 2021

danilashtefan updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

I have corrected everything according to the previous comments. Wallace will kindly help me to format the code, since I have the following formatter error Stack dump:
0. Program arguments: clang-format -lines=1:149 -lines=0:0 lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
/lib/x86_64-linux-gnu/libLLVM-10.so.1(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x1f)[0x7fa7b5d204ff]
/lib/x86_64-linux-gnu/libLLVM-10.so.1(_ZN4llvm3sys17RunSignalHandlersEv+0x50)[0x7fa7b5d1e7b0]
/lib/x86_64-linux-gnu/libLLVM-10.so.1(+0x981ac5)[0x7fa7b5d20ac5]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0)[0x7fa7bc4f03c0]
/lib/x86_64-linux-gnu/libclang-cpp.so.10(_ZNK5clang13SourceManager16translateLineColENS_6FileIDEjj+0xcf)[0x7fa7ba1cc83f]
clang-format[0x407e10]
clang-format[0x406b64]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0x7fa7b4e4e0b3]
clang-format[0x40652e]
error: clang-format -lines=1:149 -lines=0:0 lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp failed

Oct 25 2021, 11:15 AM · Restricted Project

Oct 23 2021

danilashtefan commandeered D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 23 2021, 1:47 AM · Restricted Project

Oct 20 2021

danilashtefan requested review of D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 20 2021, 1:55 PM · Restricted Project