[fir] Keep runtime function name in comment

[clementval]

Summary

Some of the function name in the comment didn't match
their actual name in the runtime. This patch fixes that.

flang/include/flang/Optimizer/Builder/Runtime/Reduction.h

 
 namespace fir {
 class ExtendedValue;
 class FirOpBuilder;
 } // namespace fir
 
 namespace fir::runtime {
 
-/// Generate call to `all` runtime routine.
+/// Generate call to `AllDim` runtime routine.
 /// This calls the descriptor based runtime call implementation of the `all`
 /// intrinsic.
 void genAllDescriptor(fir::FirOpBuilder &builder, mlir::Location loc,
                       mlir::Value resultBox, mlir::Value maskBox,
                       mlir::Value dim);
 
-/// Generate call to `any` runtime routine.
+/// Generate call to `AnyDim` runtime routine.
 /// This calls the descriptor based runtime call implementation of the `any`
 /// intrinsic.
 void genAnyDescriptor(fir::FirOpBuilder &builder, mlir::Location loc,
                       mlir::Value resultBox, mlir::Value maskBox,
                       mlir::Value dim);
 
-/// Generate call to `all` runtime routine. This version of `all` is specialized
+/// Generate call to `All` runtime routine. This version of `all` is specialized
 /// for rank 1 mask arguments.
 /// This calls the version that returns a scalar logical value.
 mlir::Value genAll(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value maskBox, mlir::Value dim);
 
-/// Generate call to `any` runtime routine. This version of `any` is specialized
+/// Generate call to `Any` runtime routine. This version of `any` is specialized
 /// for rank 1 mask arguments.
 /// This calls the version that returns a scalar logical value.
 mlir::Value genAny(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value maskBox, mlir::Value dim);
 
-/// Generate call to `count` runtime routine. This routine is a specialized
+/// Generate call to `Count` runtime routine. This routine is a specialized
 /// version when mask is a rank one array or the dim argument is not
 /// specified by the user.
 mlir::Value genCount(fir::FirOpBuilder &builder, mlir::Location loc,
                      mlir::Value maskBox, mlir::Value dim);
 
-/// Generate call to general CountDim runtime routine. This routine has a
+/// Generate call to general `CountDim` runtime routine. This routine has a
 /// descriptor result.
 void genCountDim(fir::FirOpBuilder &builder, mlir::Location loc,
                  mlir::Value resultBox, mlir::Value maskBox, mlir::Value dim,
                  mlir::Value kind);
 
-/// Generate call to `dot_product` intrinsic runtime routine.
+/// Generate call to `DotProduct` intrinsic runtime routine.
 mlir::Value genDotProduct(fir::FirOpBuilder &builder, mlir::Location loc,
                           mlir::Value vectorABox, mlir::Value vectorBBox,
                           mlir::Value resultBox);
 
-/// Generate call to `maxloc` intrinsic runtime routine. This is the version
+/// Generate call to `Maxloc` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 void genMaxloc(fir::FirOpBuilder &builder, mlir::Location loc,
                mlir::Value resultBox, mlir::Value arrayBox, mlir::Value maskBox,
                mlir::Value kind, mlir::Value back);
 
-/// Generate call to `maxloc` intrinsic runtime routine. This is the version
+/// Generate call to `MaxlocDim` intrinsic runtime routine. This is the version
 /// that takes a dim argument.
 void genMaxlocDim(fir::FirOpBuilder &builder, mlir::Location loc,
                   mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                   mlir::Value maskBox, mlir::Value kind, mlir::Value back);
 
-/// Generate call to `minloc` intrinsic runtime routine. This is the version
+/// Generate call to `Minloc` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 void genMinloc(fir::FirOpBuilder &builder, mlir::Location loc,
                mlir::Value resultBox, mlir::Value arrayBox, mlir::Value maskBox,
                mlir::Value kind, mlir::Value back);
 
-/// Generate call to `minloc` intrinsic runtime routine. This is the version
+/// Generate call to `MinlocDim` intrinsic runtime routine. This is the version
 /// that takes a dim argument.
 void genMinlocDim(fir::FirOpBuilder &builder, mlir::Location loc,
                   mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                   mlir::Value maskBox, mlir::Value kind, mlir::Value back);
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
+/// Generate call to `Maxval` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value genMaxval(fir::FirOpBuilder &builder, mlir::Location loc,
                       mlir::Value arrayBox, mlir::Value maskBox);
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
-/// that that handles 1 dimensional character arrays  with no DIM argument.
+/// Generate call to `MaxvalCharacter` intrinsic runtime routine. This is the
+/// version hat that handles 1 dimensional character arrays  with no DIM
+/// argument.
 void genMaxvalChar(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value resultBox, mlir::Value arrayBox,
                    mlir::Value maskBox);
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
+/// Generate call to `MaxvalDim` intrinsic runtime routine. This is the version
 /// that takes arrays of any rank with a dim argument specified.
 void genMaxvalDim(fir::FirOpBuilder &builder, mlir::Location loc,
                   mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                   mlir::Value maskBox);
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
+/// Generate call to `Minval` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value genMinval(fir::FirOpBuilder &builder, mlir::Location loc,
                       mlir::Value arrayBox, mlir::Value maskBox);
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
-/// that that handles 1 dimensional character arrays with no DIM argument.
+/// Generate call to `MinvalCharacter` intrinsic runtime routine. This is the
+/// version that that handles 1 dimensional character arrays with no DIM
+/// argument.
 void genMinvalChar(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value resultBox, mlir::Value arrayBox,
                    mlir::Value maskBox);
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
+/// Generate call to `MinvalDim` intrinsic runtime routine. This is the version
 /// that takes arrays of any rank with a dim argument specified.
 void genMinvalDim(fir::FirOpBuilder &builder, mlir::Location loc,
                   mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                   mlir::Value maskBox);
 
-/// Generate call to `product` intrinsic runtime routine. This is the version
+/// Generate call to `Product` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value genProduct(fir::FirOpBuilder &builder, mlir::Location loc,
                        mlir::Value arrayBox, mlir::Value maskBox,
                        mlir::Value resultBox);
 
-/// Generate call to `product` intrinsic runtime routine. This is the version
+/// Generate call to `ProductDim` intrinsic runtime routine. This is the version
 /// that takes arrays of any rank with a dim argument specified.
 void genProductDim(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                    mlir::Value maskBox);
 
-/// Generate call to `sum` intrinsic runtime routine. This is the version
+/// Generate call to `Sum` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value genSum(fir::FirOpBuilder &builder, mlir::Location loc,
                    mlir::Value arrayBox, mlir::Value maskBox,
                    mlir::Value resultBox);
 
-/// Generate call to `sum` intrinsic runtime routine. This is the version
+/// Generate call to `SumDim` intrinsic runtime routine. This is the version
 /// that takes arrays of any rank with a dim argument specified.
 void genSumDim(fir::FirOpBuilder &builder, mlir::Location loc,
                mlir::Value resultBox, mlir::Value arrayBox, mlir::Value dim,
                mlir::Value maskBox);
 
 } // namespace fir::runtime
 
 #endif // FORTRAN_OPTIMIZER_BUILDER_RUNTIME_REDUCTION_H

flang/lib/Optimizer/Builder/Runtime/Reduction.cpp

genReduction5Args(FN func, fir::FirOpBuilder &builder, mlir::Location loc,
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(5));
   auto args = fir::runtime::createArguments(builder, loc, fTy, resultBox,
                                             arrayBox, kind, dim, sourceFile,
                                             sourceLine, maskBox, back);
   builder.create<fir::CallOp>(loc, func, args);
 }
 
-/// Generate call to `all` runtime routine.
+/// Generate call to `AllDim` runtime routine.
 /// This calls the descriptor based runtime call implementation of the `all`
 /// intrinsic.
 void fir::runtime::genAllDescriptor(fir::FirOpBuilder &builder,
                                     mlir::Location loc, mlir::Value resultBox,
                                     mlir::Value maskBox, mlir::Value dim) {
   auto allFunc = fir::runtime::getRuntimeFunc<mkRTKey(AllDim)>(loc, builder);
   genReduction2Args(allFunc, builder, loc, resultBox, maskBox, dim);
 }
 
-/// Generate call to `any` runtime routine.
+/// Generate call to `AnyDim` runtime routine.
 /// This calls the descriptor based runtime call implementation of the `any`
 /// intrinsic.
 void fir::runtime::genAnyDescriptor(fir::FirOpBuilder &builder,
                                     mlir::Location loc, mlir::Value resultBox,
                                     mlir::Value maskBox, mlir::Value dim) {
   auto anyFunc = fir::runtime::getRuntimeFunc<mkRTKey(AnyDim)>(loc, builder);
   genReduction2Args(anyFunc, builder, loc, resultBox, maskBox, dim);
 }
 
-/// Generate call to `all` intrinsic runtime routine. This routine is
+/// Generate call to `All` intrinsic runtime routine. This routine is
 /// specialized for mask arguments with rank == 1.
 mlir::Value fir::runtime::genAll(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value maskBox, mlir::Value dim) {
   auto allFunc = fir::runtime::getRuntimeFunc<mkRTKey(All)>(loc, builder);
   return genSpecial2Args(allFunc, builder, loc, maskBox, dim);
 }
 
-/// Generate call to `any` intrinsic runtime routine. This routine is
+/// Generate call to `Any` intrinsic runtime routine. This routine is
 /// specialized for mask arguments with rank == 1.
 mlir::Value fir::runtime::genAny(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value maskBox, mlir::Value dim) {
   auto anyFunc = fir::runtime::getRuntimeFunc<mkRTKey(Any)>(loc, builder);
   return genSpecial2Args(anyFunc, builder, loc, maskBox, dim);
 }
 
-/// Generate call to `count` runtime routine. This routine is a specialized
+/// Generate call to `Count` runtime routine. This routine is a specialized
 /// version when mask is a rank one array or the dim argument is not
 /// specified by the user.
 mlir::Value fir::runtime::genCount(fir::FirOpBuilder &builder,
                                    mlir::Location loc, mlir::Value maskBox,
                                    mlir::Value dim) {
   auto countFunc = fir::runtime::getRuntimeFunc<mkRTKey(Count)>(loc, builder);
   return genSpecial2Args(countFunc, builder, loc, maskBox, dim);
 }
 
-/// Generate call to general CountDim runtime routine. This routine has a
+/// Generate call to general `CountDim` runtime routine. This routine has a
 /// descriptor result.
 void fir::runtime::genCountDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                mlir::Value resultBox, mlir::Value maskBox,
                                mlir::Value dim, mlir::Value kind) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(CountDim)>(loc, builder);
   auto fTy = func.getType();
   auto sourceFile = fir::factory::locationToFilename(builder, loc);
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(5));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, resultBox, maskBox, dim, kind, sourceFile, sourceLine);
   builder.create<fir::CallOp>(loc, func, args);
 }
 
-/// Generate call to `maxloc` intrinsic runtime routine. This is the version
+/// Generate call to `Maxloc` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 void fir::runtime::genMaxloc(fir::FirOpBuilder &builder, mlir::Location loc,
                              mlir::Value resultBox, mlir::Value arrayBox,
                              mlir::Value maskBox, mlir::Value kind,
                              mlir::Value back) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(Maxloc)>(loc, builder);
   genReduction4Args(func, builder, loc, resultBox, arrayBox, maskBox, kind,
                     back);
 }
 
-/// Generate call to `maxloc` intrinsic runtime routine. This is the version
+/// Generate call to `MaxlocDim` intrinsic runtime routine. This is the version
 /// that takes a dim argument.
 void fir::runtime::genMaxlocDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                 mlir::Value resultBox, mlir::Value arrayBox,
                                 mlir::Value dim, mlir::Value maskBox,
                                 mlir::Value kind, mlir::Value back) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(MaxlocDim)>(loc, builder);
   genReduction5Args(func, builder, loc, resultBox, arrayBox, dim, maskBox, kind,
                     back);
 }
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
+/// Generate call to `Maxval` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value fir::runtime::genMaxval(fir::FirOpBuilder &builder,
                                     mlir::Location loc, mlir::Value arrayBox,
                                     mlir::Value maskBox) {
   mlir::FuncOp func;
   auto ty = arrayBox.getType();
   auto arrTy = fir::dyn_cast_ptrOrBoxEleTy(ty);
   auto eleTy = arrTy.cast<fir::SequenceType>().getEleTy();
mlir::Value fir::runtime::genMaxval(fir::FirOpBuilder &builder,
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(2));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, arrayBox, sourceFile, sourceLine, dim, maskBox);
 
   return builder.create<fir::CallOp>(loc, func, args).getResult(0);
 }
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
+/// Generate call to `MaxvalDim` intrinsic runtime routine. This is the version
 /// that handles any rank array with the dim argument specified.
 void fir::runtime::genMaxvalDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                 mlir::Value resultBox, mlir::Value arrayBox,
                                 mlir::Value dim, mlir::Value maskBox) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(MaxvalDim)>(loc, builder);
   genReduction3Args(func, builder, loc, resultBox, arrayBox, dim, maskBox);
 }
 
-/// Generate call to `maxval` intrinsic runtime routine. This is the version
-/// that handles character arrays of rank 1 and without a DIM argument.
+/// Generate call to `MaxvalCharacter` intrinsic runtime routine. This is the
+/// version that handles character arrays of rank 1 and without a DIM argument.
 void fir::runtime::genMaxvalChar(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value resultBox, mlir::Value arrayBox,
                                  mlir::Value maskBox) {
   auto func =
       fir::runtime::getRuntimeFunc<mkRTKey(MaxvalCharacter)>(loc, builder);
   auto fTy = func.getType();
   auto sourceFile = fir::factory::locationToFilename(builder, loc);
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(3));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, resultBox, arrayBox, sourceFile, sourceLine, maskBox);
   builder.create<fir::CallOp>(loc, func, args);
 }
 
-/// Generate call to `minloc` intrinsic runtime routine. This is the version
+/// Generate call to `Minloc` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 void fir::runtime::genMinloc(fir::FirOpBuilder &builder, mlir::Location loc,
                              mlir::Value resultBox, mlir::Value arrayBox,
                              mlir::Value maskBox, mlir::Value kind,
                              mlir::Value back) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(Minloc)>(loc, builder);
   genReduction4Args(func, builder, loc, resultBox, arrayBox, maskBox, kind,
                     back);
 }
 
-/// Generate call to `minloc` intrinsic runtime routine. This is the version
+/// Generate call to `MinlocDim` intrinsic runtime routine. This is the version
 /// that takes a dim argument.
 void fir::runtime::genMinlocDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                 mlir::Value resultBox, mlir::Value arrayBox,
                                 mlir::Value dim, mlir::Value maskBox,
                                 mlir::Value kind, mlir::Value back) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(MinlocDim)>(loc, builder);
   genReduction5Args(func, builder, loc, resultBox, arrayBox, dim, maskBox, kind,
                     back);
 }
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
+/// Generate call to `MinvalDim` intrinsic runtime routine. This is the version
 /// that handles any rank array with the dim argument specified.
 void fir::runtime::genMinvalDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                 mlir::Value resultBox, mlir::Value arrayBox,
                                 mlir::Value dim, mlir::Value maskBox) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(MinvalDim)>(loc, builder);
   genReduction3Args(func, builder, loc, resultBox, arrayBox, dim, maskBox);
 }
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
-/// that handles character arrays of rank 1 and without a DIM argument.
+/// Generate call to `MinvalCharacter` intrinsic runtime routine. This is the
+/// version that handles character arrays of rank 1 and without a DIM argument.
 void fir::runtime::genMinvalChar(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value resultBox, mlir::Value arrayBox,
                                  mlir::Value maskBox) {
   auto func =
       fir::runtime::getRuntimeFunc<mkRTKey(MinvalCharacter)>(loc, builder);
   auto fTy = func.getType();
   auto sourceFile = fir::factory::locationToFilename(builder, loc);
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(3));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, resultBox, arrayBox, sourceFile, sourceLine, maskBox);
   builder.create<fir::CallOp>(loc, func, args);
 }
 
-/// Generate call to `minval` intrinsic runtime routine. This is the version
+/// Generate call to `Minval` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value fir::runtime::genMinval(fir::FirOpBuilder &builder,
                                     mlir::Location loc, mlir::Value arrayBox,
                                     mlir::Value maskBox) {
   mlir::FuncOp func;
   auto ty = arrayBox.getType();
   auto arrTy = fir::dyn_cast_ptrOrBoxEleTy(ty);
   auto eleTy = arrTy.cast<fir::SequenceType>().getEleTy();
mlir::Value fir::runtime::genMinval(fir::FirOpBuilder &builder,
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(2));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, arrayBox, sourceFile, sourceLine, dim, maskBox);
 
   return builder.create<fir::CallOp>(loc, func, args).getResult(0);
 }
 
-/// Generate call to `product` intrinsic runtime routine. This is the version
+/// Generate call to `ProductDim` intrinsic runtime routine. This is the version
 /// that handles any rank array with the dim argument specified.
 void fir::runtime::genProductDim(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value resultBox, mlir::Value arrayBox,
                                  mlir::Value dim, mlir::Value maskBox) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(ProductDim)>(loc, builder);
   genReduction3Args(func, builder, loc, resultBox, arrayBox, dim, maskBox);
 }
 
-/// Generate call to `product` intrinsic runtime routine. This is the version
+/// Generate call to `Product` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value fir::runtime::genProduct(fir::FirOpBuilder &builder,
                                      mlir::Location loc, mlir::Value arrayBox,
                                      mlir::Value maskBox,
                                      mlir::Value resultBox) {
   mlir::FuncOp func;
   auto ty = arrayBox.getType();
   auto arrTy = fir::dyn_cast_ptrOrBoxEleTy(ty);
mlir::Value fir::runtime::genProduct(fir::FirOpBuilder &builder,
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(2));
   auto args = fir::runtime::createArguments(
       builder, loc, fTy, arrayBox, sourceFile, sourceLine, dim, maskBox);
 
   return builder.create<fir::CallOp>(loc, func, args).getResult(0);
 }
 
-/// Generate call to `dot_product` intrinsic runtime routine.
+/// Generate call to `DotProduct` intrinsic runtime routine.
 mlir::Value fir::runtime::genDotProduct(fir::FirOpBuilder &builder,
                                         mlir::Location loc,
                                         mlir::Value vectorABox,
                                         mlir::Value vectorBBox,
                                         mlir::Value resultBox) {
   mlir::FuncOp func;
   auto ty = vectorABox.getType();
   auto arrTy = fir::dyn_cast_ptrOrBoxEleTy(ty);
mlir::Value fir::runtime::genDotProduct(fir::FirOpBuilder &builder,
   }
 
   auto sourceLine =
       fir::factory::locationToLineNo(builder, loc, fTy.getInput(3));
   auto args = fir::runtime::createArguments(builder, loc, fTy, vectorABox,
                                             vectorBBox, sourceFile, sourceLine);
   return builder.create<fir::CallOp>(loc, func, args).getResult(0);
 }
-/// Generate call to Sum intrinsic runtime routine. This is the version
+/// Generate call to `SumDim` intrinsic runtime routine. This is the version
 /// that handles any rank array with the dim argument specified.
 void fir::runtime::genSumDim(fir::FirOpBuilder &builder, mlir::Location loc,
                              mlir::Value resultBox, mlir::Value arrayBox,
                              mlir::Value dim, mlir::Value maskBox) {
   auto func = fir::runtime::getRuntimeFunc<mkRTKey(SumDim)>(loc, builder);
   genReduction3Args(func, builder, loc, resultBox, arrayBox, dim, maskBox);
 }
 
-/// Generate call to `sum` intrinsic runtime routine. This is the version
+/// Generate call to `Sum` intrinsic runtime routine. This is the version
 /// that does not take a dim argument.
 mlir::Value fir::runtime::genSum(fir::FirOpBuilder &builder, mlir::Location loc,
                                  mlir::Value arrayBox, mlir::Value maskBox,
                                  mlir::Value resultBox) {
   mlir::FuncOp func;
   auto ty = arrayBox.getType();
   auto arrTy = fir::dyn_cast_ptrOrBoxEleTy(ty);
   auto eleTy = arrTy.cast<fir::SequenceType>().getEleTy();