Details
Details
Diff Detail
Diff Detail
Event Timeline
clang/lib/Format/ContinuationIndenter.cpp | ||
---|---|---|
1294–1296 | Unrelated to your change, it only shed light on this: Shouldn't it be this? |
clang/lib/Format/ContinuationIndenter.cpp | ||
---|---|---|
1294–1296 | Yeah, I will update it. |
clang/lib/Format/ContinuationIndenter.cpp | ||
---|---|---|
1294–1296 | This is in my view one of the reasons why I personally like it when we comment the condition with an example and don't have these huge compound expressions. Often they are covering corner cases. (we should call them out) |
Unrelated to your change, it only shed light on this:
This condition looks strange to me. How can Previous be at the same time two different TokenTypes (?), for instance, both TT_BinaryOperator and TT_DictLiteral?
Shouldn't it be this?