This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][NFC] Reorder conditions
ClosedPublic

Authored by HazardyKnusperkeks on Dec 3 2021, 11:56 AM.

Reviewers

Commits

rG4483e9b5279b: [clang-format][NFC] Reorder conditions

Summary

Prefer to check the local variables first before dereferencing the pointer.

HazardyKnusperkeks created this revision.

LGTM.

This revision is now accepted and ready to land.Dec 3 2021, 12:51 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

lib/

Format/

4 lines

Show First 20 Lines • Show All 2,167 Lines • ▼ Show 20 Lines	void parse(int Precedence = 0) {
unsigned OperatorIndex = 0;		unsigned OperatorIndex = 0;

while (Current) {		while (Current) {
// Consume operators with higher precedence.		// Consume operators with higher precedence.
parse(Precedence + 1);		parse(Precedence + 1);

int CurrentPrecedence = getCurrentPrecedence();		int CurrentPrecedence = getCurrentPrecedence();

if (Current && Current->is(TT_SelectorName) &&		if (Precedence == CurrentPrecedence && Current &&
Precedence == CurrentPrecedence) {		Current->is(TT_SelectorName)) {
if (LatestOperator)		if (LatestOperator)
addFakeParenthesis(Start, prec::Level(Precedence));		addFakeParenthesis(Start, prec::Level(Precedence));
Start = Current;		Start = Current;
}		}

// At the end of the line or when an operator with higher precedence is		// At the end of the line or when an operator with higher precedence is
// found, insert fake parenthesis and return.		// found, insert fake parenthesis and return.
if (!Current \|\|		if (!Current \|\|
▲ Show 20 Lines • Show All 2,227 Lines • Show Last 20 Lines