This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][modularisation] modularises <numeric> header
ClosedPublic

Authored by cjdb on Nov 30 2021, 5:37 PM.

Details

Diff Detail

Event Timeline

cjdb created this revision.Nov 30 2021, 5:37 PM
cjdb requested review of this revision.Nov 30 2021, 5:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2021, 5:37 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 390876.Nov 30 2021, 5:40 PM

added newline to EOF

ldionne accepted this revision.Dec 1 2021, 7:36 AM

LGTM, but you need to run libcxx-generate-files to pass CI.

Also, I'm assuming you didn't modify any content, just moved stuff around (as usual for these modularization patches). If you did change something, please call it out.

Thanks, fee free to ship this once CI is passing!

This revision is now accepted and ready to land.Dec 1 2021, 7:36 AM
cjdb updated this revision to Diff 391046.Dec 1 2021, 8:42 AM

adds generated files

This revision was automatically updated to reflect the committed changes.