Page MenuHomePhabricator

[mlir][linalg] Fix windows build issue in hoist padding.
ClosedPublic

Authored by gysit on Nov 29 2021, 11:54 PM.

Details

Summary

Iterating backwardSlice and removing elements at the same time can fail on windows for specific build configurations (the code was introduced in https://reviews.llvm.org/D114420). This revision introduces a second vector to collect all operations and removes them after finishing the reverse iteration.

Diff Detail

Event Timeline

gysit created this revision.Nov 29 2021, 11:54 PM
gysit requested review of this revision.Nov 29 2021, 11:54 PM
gysit added a subscriber: hpmorgan.

@hpmorgan I hope I found the right henry morgan and this fixes the issue. Let's follow up here!

hpmorgan accepted this revision.Nov 30 2021, 7:04 AM

Looks good to me. Thanks Tobias!

This revision is now accepted and ready to land.Nov 30 2021, 7:04 AM
This revision was automatically updated to reflect the committed changes.