This is an archive of the discontinued LLVM Phabricator instance.

[flang] Address TODO from previous changes to IsSaved()
ClosedPublic

Authored by klausler on Nov 29 2021, 3:41 PM.

Details

Summary

An earlier fix to evaluate::IsSaved() needed to preserve its
treatment of named constants in modules and main programs -- i.e.
they would appear to be saved -- until a correction was added
to the lowering code. This TODO can now be resolved.

Diff Detail

Event Timeline

klausler created this revision.Nov 29 2021, 3:41 PM
klausler requested review of this revision.Nov 29 2021, 3:41 PM
jeanPerier accepted this revision.Nov 30 2021, 12:32 AM
This revision is now accepted and ready to land.Nov 30 2021, 12:32 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2021, 10:40 AM