This is an archive of the discontinued LLVM Phabricator instance.

Correct x86_64 Android fp128 mangled name
ClosedPublic

Authored by chh on Jul 23 2015, 10:21 AM.

Diff Detail

Event Timeline

chh updated this revision to Diff 30501.Jul 23 2015, 10:21 AM
chh retitled this revision from to Correct x86_64 Android fp128 mangled name.
chh updated this object.
chh added reviewers: majnemer, echristo.
chh added subscribers: cfe-commits, davidxl, rnk and 4 others.
rnk added inline comments.Jul 23 2015, 10:26 AM
test/CodeGen/x86-long-double.cpp
1–12 ↗(On Diff #30501)

Don't use %clang in CodeGen tests.

majnemer added inline comments.Jul 23 2015, 10:35 AM
test/CodeGen/x86-long-double.cpp
5–6 ↗(On Diff #30501)

This test is called x86-long-double.cpp but you have powerpc tests here.

chh updated this revision to Diff 30502.Jul 23 2015, 10:42 AM

Use %clang_cc1 in unit test.

chh updated this revision to Diff 30504.Jul 23 2015, 10:49 AM

Change unit test name to long_double_fp128.

rnk added a comment.Jul 23 2015, 10:56 AM

Thanks, this seems almost done. Sorry for missing the -O on the first round.

test/CodeGen/long_double_fp128.cpp
1

I don't think these tests need optimizations (-O).

echristo added inline comments.Jul 23 2015, 10:58 AM
test/CodeGen/long_double_fp128.cpp
1

If they do there's a different problem :)

chh updated this revision to Diff 30505.Jul 23 2015, 11:09 AM

Remove -O from unit tests.

rnk accepted this revision.Jul 23 2015, 1:42 PM
rnk added a reviewer: rnk.

lgtm

This revision is now accepted and ready to land.Jul 23 2015, 1:42 PM
chh added a comment.Jul 23 2015, 3:08 PM

Thanks for the review and approval.

I will commit this patch when I get my commit access request approved.
If anyone can help me commit this patch, please go ahead.
Thank you.

This revision was automatically updated to reflect the committed changes.