[mlir] Enable MLIRDialectUtilsTests

[Chia-hungDuan]

Summary

Also remove TooFewDims test which tried to create an invalid AffineMap.
The creation of an invalid AffineMap is rejected by willBeValidAffineMap,
as a result we can deprecate the test.

[bondhugula]

mlir/unittests/Dialect/CMakeLists.txt

10

Please add in sorted order.

mlir/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp

119

This is building an incorrect affine map since its expressions involve up to d2 (k is d2 here) while the map is being created with only two input dims. Just change this to ...(3, 0, ...).

[Chia-hungDuan]

mlir/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp

119

If we change it into ...(3, 0, ...)..., then it'll be the same test cases as TEST(isRowMajorMatmul, Simple) above. Any suggestions?

[Chia-hungDuan]

Address review

[bondhugula]

mlir/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp

119

Oh, then please update the commit summary. It's currently misleading when it states "Also remove a test which has been asserted by willBeValidAffineMap.".

[Chia-hungDuan]

update commit message

mlir/unittests/Dialect/CMakeLists.txt

 add_mlir_unittest(MLIRDialectTests
   BroadcastShapeTest.cpp
 )
 target_link_libraries(MLIRDialectTests
   PRIVATE
   MLIRIR
   MLIRDialect)
 
 add_subdirectory(Quant)
 add_subdirectory(SparseTensor)
 add_subdirectory(SPIRV)
+add_subdirectory(Utils)

mlir/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp

TEST(isRowMajorMatmul, TooManyMaps) {
   auto mapC = AffineMapAttr::get(AffineMap::get(3, 0, {m, n}, &context));
   auto mapD = AffineMapAttr::get(AffineMap::get(3, 0, {k, m}, &context));
 
   auto maps = ArrayAttr::get(&context, {mapA, mapB, mapC, mapD});
 
   EXPECT_THAT(maps, Not(Truly(isRowMajorMatmul)));
 }
 
-TEST(isRowMajorMatmul, TooFewDims) {
-  MLIRContext context;
-
-  AffineExpr m, n, k;
-  bindDims(&context, m, n, k);
-  auto mapA = AffineMapAttr::get(AffineMap::get(3, 0, {m, k}, &context));
-  auto mapB = AffineMapAttr::get(AffineMap::get(2, 0, {k, n}, &context));
-  auto mapC = AffineMapAttr::get(AffineMap::get(3, 0, {m, n}, &context));
-  auto maps = ArrayAttr::get(&context, {mapA, mapB, mapC});
-
-  EXPECT_THAT(maps, Not(Truly(isRowMajorMatmul)));
-}
-
 TEST(isRowMajorMatmul, TooFewOutputs) {
   MLIRContext context;
 
   AffineExpr m, n, k;
   bindDims(&context, m, n, k);
   auto mapA = AffineMapAttr::get(AffineMap::get(3, 0, {m}, &context));
   auto mapB = AffineMapAttr::get(AffineMap::get(3, 0, {k, n}, &context));
   auto mapC = AffineMapAttr::get(AffineMap::get(3, 0, {m, n}, &context));