This is an archive of the discontinued LLVM Phabricator instance.

tsan: enable -msse4 when compiling tests
ClosedPublic

Authored by dvyukov on Nov 25 2021, 6:49 AM.

Details

Summary

Vector SSE accesses make compiler emit __tsan_[unaligned_]read/write16 callbacks.
Make it possible to test these.

Diff Detail

Event Timeline

dvyukov created this revision.Nov 25 2021, 6:49 AM
dvyukov requested review of this revision.Nov 25 2021, 6:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2021, 6:49 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Nov 25 2021, 7:12 AM

Is COMPILER_RT_HAS_MSSE4_2_FLAG only true if the host has support?

If not, I'm sure there are people who run something that doesn't support SSE 4.2. For us it's fine, so let's see which bots complain.

This revision is now accepted and ready to land.Nov 25 2021, 7:12 AM

Is COMPILER_RT_HAS_MSSE4_2_FLAG only true if the host has support?

If not, I'm sure there are people who run something that doesn't support SSE 4.2. For us it's fine, so let's see which bots complain.

We use COMPILER_RT_HAS_MSSE4_2_FLAG to add -msee4 when building the runtime itself. So I assume it works one way or another.

This revision was automatically updated to reflect the committed changes.