[LLDB][NativePDB] Allow find functions by full names

[zequanwu]

Summary

I don't see a reason why not to. If we allows lookup functions by full names,
I can change the test case in D113930 to use lldb-test symbols --find=function --name=full::name --function-flags=full ...,
though the duplicate method decl prolem is still there for lldb-test symbols --dump-ast.
That's a seprate bug, we can fix it later.

[stella.stamenova]

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12270

I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today.

[zequanwu]

In D114467#3158778, @stella.stamenova wrote:

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12270

I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today.

Thanks, https://reviews.llvm.org/rG34d02fada28753221eda576e2f651f9b23c3f1af should fix it.

[stella.stamenova]

@zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413

[zequanwu]

In D114467#3158960, @stella.stamenova wrote:

@zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413

The printed names are different between windows and linux. https://reviews.llvm.org/rGfe270ab061fa1200d1f7e121ac6671f7d24b73d6 would hopefully fix it.

[labath]

What is the reason for these differences? The test in question appears to be fairly hermetic (in-tree compiler and linker), so it sounds like something is going wrong inside lldb...

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

void SymbolFileNativePDB::FindGlobalVariables(
   }
 }
 
 void SymbolFileNativePDB::FindFunctions(
     ConstString name, const CompilerDeclContext &parent_decl_ctx,
     FunctionNameType name_type_mask, bool include_inlines,
     SymbolContextList &sc_list) {
   std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
-  // For now we only support lookup by method name.
-  if (!(name_type_mask & eFunctionNameTypeMethod))
+  // For now we only support lookup by method name or full name.
+  if (!(name_type_mask & eFunctionNameTypeFull ||
+        name_type_mask & eFunctionNameTypeMethod))
     return;
 
   using SymbolAndOffset = std::pair<uint32_t, llvm::codeview::CVSymbol>;
 
   std::vector<SymbolAndOffset> matches = m_index->globals().findRecordsByName(
       name.GetStringRef(), m_index->symrecords());
   for (const SymbolAndOffset &match : matches) {
     if (match.second.kind() != S_PROCREF && match.second.kind() != S_LPROCREF)

lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp

+// clang-format off
+// REQUIRES: lld, x86
+
+// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s
+// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb
+
+// RUN: lldb-test symbols --find=function --name=main --function-flags=full %t.exe \
+// RUN:     | FileCheck %s --check-prefix=FIND-MAIN
+
+// RUN: lldb-test symbols --find=function --name=static_fn --function-flags=full %t.exe \
+// RUN:     | FileCheck %s --check-prefix=FIND-STATIC
+
+// RUN: lldb-test symbols --find=function --name=varargs_fn --function-flags=full %t.exe \
+// RUN:     | FileCheck %s --check-prefix=FIND-VAR
+
+static int static_fn() {
+  return 42;
+}
+
+int varargs_fn(int x, int y, ...) {
+  return x + y;
+}
+
+int main(int argc, char **argv) {
+  return static_fn() + varargs_fn(argc, argc);
+}
+
+// FIND-MAIN:      Function: id = {{.*}}, name = "main"
+// FIND-MAIN-NEXT: FuncType: id = {{.*}}, byte-size = 0, compiler_type = "int (int, char **)"
+
+// FIND-STATIC:      Function: id = {{.*}}, name = "static_fn"
+// FIND-STATIC-NEXT: FuncType: id = {{.*}}, byte-size = 0, compiler_type = "int (void)"
+
+// FIND-VAR:      Function: id = {{.*}}, name = "varargs_fn"
+// FIND-VAR-NEXT: FuncType: id = {{.*}}, byte-size = 0, compiler_type = "int (int, int, ...)"