Page MenuHomePhabricator

[LLDB][NativePDB] Allow find functions by full names
ClosedPublic

Authored by zequanwu on Nov 23 2021, 12:31 PM.

Details

Summary

I don't see a reason why not to. If we allows lookup functions by full names,
I can change the test case in D113930 to use lldb-test symbols --find=function --name=full::name --function-flags=full ...,
though the duplicate method decl prolem is still there for lldb-test symbols --dump-ast.
That's a seprate bug, we can fix it later.

Diff Detail

Event Timeline

zequanwu requested review of this revision.Nov 23 2021, 12:31 PM
zequanwu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2021, 12:31 PM
labath accepted this revision.Nov 23 2021, 12:37 PM
This revision is now accepted and ready to land.Nov 23 2021, 12:37 PM
This revision was automatically updated to reflect the committed changes.

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12270

I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today.

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12270

I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today.

Thanks, https://reviews.llvm.org/rG34d02fada28753221eda576e2f651f9b23c3f1af should fix it.

The printed names are different between windows and linux. https://reviews.llvm.org/rGfe270ab061fa1200d1f7e121ac6671f7d24b73d6 would hopefully fix it.

What is the reason for these differences? The test in question appears to be fairly hermetic (in-tree compiler and linker), so it sounds like something is going wrong inside lldb...