This is an archive of the discontinued LLVM Phabricator instance.

tsan: disable instrumentation in runtime callbacks in tests
ClosedPublic

Authored by dvyukov on Nov 21 2021, 11:38 PM.

Details

Summary

All runtime callbacks must be non-instrumented with the new tsan runtime
(it's now more picky with respect to recursion into runtime).
Disable instrumentation in Darwin tests as we do in all other tests now.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Nov 21 2021, 11:38 PM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2021, 11:38 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2021, 6:48 AM
This revision was automatically updated to reflect the committed changes.

Julian, please post-review. I want to do another pre-submit of tsanv3 change and need this to get these failures off the plate.

yln added a comment.Nov 29 2021, 8:37 PM

Julian, please post-review. I want to do another pre-submit of tsanv3 change and need this to get these failures off the plate.

This fixes the failing tests. Thanks!