Page MenuHomePhabricator

[MLIR] Avoid creation of buggy affine maps while replacing dimension and symbol
ClosedPublic

Authored by arnab-oss on Nov 19 2021, 5:30 AM.

Details

Summary

Initially before appending the newly composed dimension and symbols
to the dimension and symbol list whose size is to be passed in
AffineMap::get(), the call to the AffineMap::get() was made, resulting
in wrong dimCount and symbolCount being passed as argument. We move the
call to the AffineMap::get() after the diimension and symbol list are
updated.

Diff Detail

Event Timeline

arnab-oss created this revision.Nov 19 2021, 5:30 AM
arnab-oss requested review of this revision.Nov 19 2021, 5:30 AM
bondhugula accepted this revision.Nov 19 2021, 5:41 AM
This revision is now accepted and ready to land.Nov 19 2021, 5:41 AM
bondhugula added inline comments.Nov 19 2021, 5:41 AM
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
628

Tweak this comment to be consistent with the change and its rationale.

arnab-oss updated this revision to Diff 388478.EditedNov 19 2021, 5:45 AM

Fixed documentation @bondhugula .

bondhugula accepted this revision.Nov 19 2021, 8:03 AM

The relevant commits aren't properly stacked here. D114237 should have been at the bottom but it's instead on top of D114238. Please reorder to fix.