This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt/profile] Include __llvm_profile_get_magic in module signature
ClosedPublic

Authored by pirama on Nov 16 2021, 9:24 PM.

Details

Summary

The INSTR_PROF_RAW_MAGIC_* number in profraw files should match during
profile merging. This causes an error with 32-bit and 64-bit variants
of the same code. The module signatures for the two binaries are
identical but they use different INSTR_PROF_RAW_MAGIC_* causing a
failure when profile-merging is used. Including it when computing the
module signature yields different signatures for the 32-bit and 64-bit
profiles.

Diff Detail

Event Timeline

pirama created this revision.Nov 16 2021, 9:24 PM
pirama requested review of this revision.Nov 16 2021, 9:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 9:24 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
pirama updated this revision to Diff 387821.Nov 16 2021, 9:33 PM
pirama edited the summary of this revision. (Show Details)

reword commit message.

This revision is now accepted and ready to land.Nov 18 2021, 12:26 PM
This revision was landed with ongoing or failed builds.Nov 23 2021, 10:10 AM
This revision was automatically updated to reflect the committed changes.