This is an archive of the discontinued LLVM Phabricator instance.

Differential D114015

[Loads] Handle addrspacecast constant expressions when determining dereferenceability
ClosedPublic

Authored by aeubanks on Nov 16 2021, 11:06 AM.

Details

Reviewers
nikic
tra
Commits
rGc95a9f46c9cf: [Loads] Handle addrspacecast constant expressions when determining…

Diff Detail

Event Timeline

aeubanks created this revision.Nov 16 2021, 11:06 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptNov 16 2021, 11:06 AM
aeubanks requested review of this revision.Nov 16 2021, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 11:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks mentioned this in rG877d6e9b9aa0: [test] Precommit test for D114015.Nov 16 2021, 11:09 AM
aeubanks updated this revision to Diff 387708.Nov 16 2021, 11:10 AM

rebase

aeubanks added reviewers: nikic, tra.Nov 16 2021, 11:11 AM
nikic accepted this revision.Nov 16 2021, 11:16 AM

LG

This revision is now accepted and ready to land.Nov 16 2021, 11:16 AM
This revision was landed with ongoing or failed builds.Nov 16 2021, 11:20 AM
Closed by commit rGc95a9f46c9cf: [Loads] Handle addrspacecast constant expressions when determining… (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGc95a9f46c9cf: [Loads] Handle addrspacecast constant expressions when determining….
tra added inline comments.Nov 16 2021, 11:59 AM
llvm/lib/Analysis/Loads.cpp
150

Do we need/want to handle Instr variant as well? Or does AddrSpaceCastOperator handle both ASC variants?

aeubanks added inline comments.Nov 16 2021, 12:08 PM
llvm/lib/Analysis/Loads.cpp
150

yes AddrSpaceCastOperator handles both

Harbormaster completed remote builds in B134573: Diff 387708.Nov 16 2021, 12:38 PM

Revision Contents

PathSize
llvm/
lib/
Analysis/
2 lines
test/
Transforms/
SROA/
6 lines

Diff 387712

llvm/lib/Analysis/Loads.cpp

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Linesstatic bool isDereferenceableAndAlignedPointer(
} }
// For gc.relocate, look through relocations // For gc.relocate, look through relocations
if (const GCRelocateInst *RelocateInst = dyn_cast<GCRelocateInst>(V)) if (const GCRelocateInst *RelocateInst = dyn_cast<GCRelocateInst>(V))
return isDereferenceableAndAlignedPointer(RelocateInst->getDerivedPtr(), return isDereferenceableAndAlignedPointer(RelocateInst->getDerivedPtr(),
Alignment, Size, DL, CtxI, DT, Alignment, Size, DL, CtxI, DT,
TLI, Visited, MaxDepth); TLI, Visited, MaxDepth);
if (const AddrSpaceCastInst *ASC = dyn_cast<AddrSpaceCastInst>(V)) if (const AddrSpaceCastOperator *ASC = dyn_cast<AddrSpaceCastOperator>(V))
traUnsubmitted
Not Done
ReplyInline Actions

Do we need/want to handle Instr variant as well? Or does AddrSpaceCastOperator handle both ASC variants?

tra: Do we need/want to handle `Instr` variant as well? Or does `AddrSpaceCastOperator` handle both…
aeubanksAuthorUnsubmitted
Done
ReplyInline Actions

yes AddrSpaceCastOperator handles both

aeubanks: yes `AddrSpaceCastOperator` handles both
return isDereferenceableAndAlignedPointer(ASC->getOperand(0), Alignment, return isDereferenceableAndAlignedPointer(ASC->getOperand(0), Alignment,
Size, DL, CtxI, DT, TLI, Size, DL, CtxI, DT, TLI,
Visited, MaxDepth); Visited, MaxDepth);
if (const auto *Call = dyn_cast<CallBase>(V)) { if (const auto *Call = dyn_cast<CallBase>(V)) {
if (auto *RP = getArgumentAliasingToReturnedPointer(Call, true)) if (auto *RP = getArgumentAliasingToReturnedPointer(Call, true))
return isDereferenceableAndAlignedPointer(RP, Alignment, Size, DL, CtxI, return isDereferenceableAndAlignedPointer(RP, Alignment, Size, DL, CtxI,
DT, TLI, Visited, MaxDepth); DT, TLI, Visited, MaxDepth);
▲ Show 20 Lines • Show All 513 Lines • Show Last 20 Lines

llvm/test/Transforms/SROA/addrspacecast.ll

Show First 20 Lines • Show All 297 Lines • ▼ Show 20 Lines;
%cond.in = select i1 undef, i64 addrspace(1)* %asc, i64 addrspace(1)* @gv %cond.in = select i1 undef, i64 addrspace(1)* %asc, i64 addrspace(1)* @gv
%cond = load i64, i64 addrspace(1)* %cond.in, align 8 %cond = load i64, i64 addrspace(1)* %cond.in, align 8
ret void ret void
} }
define void @select_addrspacecast_gv_constexpr(i1 %a, i1 %b) { define void @select_addrspacecast_gv_constexpr(i1 %a, i1 %b) {
; CHECK-LABEL: @select_addrspacecast_gv_constexpr( ; CHECK-LABEL: @select_addrspacecast_gv_constexpr(
; CHECK-NEXT: [[C:%.*]] = alloca i64, align 8 ; CHECK-NEXT: [[COND_SROA_SPECULATE_LOAD_FALSE:%.*]] = load i64, i64 addrspace(2)* addrspacecast (i64 addrspace(1)* @gv to i64 addrspace(2)*), align 8
; CHECK-NEXT: [[C_0_ASC_SROA_CAST:%.*]] = addrspacecast i64* [[C]] to i64 addrspace(2)* ; CHECK-NEXT: [[COND_SROA_SPECULATED:%.*]] = select i1 undef, i64 undef, i64 [[COND_SROA_SPECULATE_LOAD_FALSE]]
; CHECK-NEXT: [[COND_IN:%.*]] = select i1 undef, i64 addrspace(2)* [[C_0_ASC_SROA_CAST]], i64 addrspace(2)* addrspacecast (i64 addrspace(1)* @gv to i64 addrspace(2)*)
; CHECK-NEXT: [[COND:%.*]] = load i64, i64 addrspace(2)* [[COND_IN]], align 8
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; ;
%c = alloca i64, align 8 %c = alloca i64, align 8
%p.0.c = select i1 undef, i64* %c, i64* %c %p.0.c = select i1 undef, i64* %c, i64* %c
%asc = addrspacecast i64* %p.0.c to i64 addrspace(2)* %asc = addrspacecast i64* %p.0.c to i64 addrspace(2)*
%cond.in = select i1 undef, i64 addrspace(2)* %asc, i64 addrspace(2)* addrspacecast (i64 addrspace(1)* @gv to i64 addrspace(2)*) %cond.in = select i1 undef, i64 addrspace(2)* %asc, i64 addrspace(2)* addrspacecast (i64 addrspace(1)* @gv to i64 addrspace(2)*)
%cond = load i64, i64 addrspace(2)* %cond.in, align 8 %cond = load i64, i64 addrspace(2)* %cond.in, align 8
Show All 24 Lines