This is an archive of the discontinued LLVM Phabricator instance.

tsan: use smaller trace parts for Go
ClosedPublic

Authored by dvyukov on Nov 16 2021, 3:43 AM.

Details

Summary

In the old runtime we used to use different number of trace parts
for C++ and Go to reduce trace memory consumption for Go.
But now it's easier and better to use smaller parts because
we already use minimal possible number of parts for C++ (3).

Diff Detail

Event Timeline

dvyukov requested review of this revision.Nov 16 2021, 3:43 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 3:43 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Nov 16 2021, 6:47 AM
melver added inline comments.
compiler-rt/lib/tsan/rtl/tsan_trace.h
195

Could do this in less code:

static constexpr uptr kByteSize = (SANITIZER_GO ? 128 : 256) << 10;
This revision is now accepted and ready to land.Nov 16 2021, 6:47 AM
dvyukov updated this revision to Diff 387622.Nov 16 2021, 6:58 AM

addressed the comment

dvyukov marked an inline comment as done.Nov 16 2021, 6:58 AM
This revision was landed with ongoing or failed builds.Nov 16 2021, 6:59 AM
This revision was automatically updated to reflect the committed changes.