v64i8` can appear after legalization, cost is same as for `trunc v8i64 to v8i8`
ClosedPublic
Actions

Authored by lebedev.ri on Nov 14 2021, 10:08 AM.

Details

Reviewers

Commits

rG9e57d9b09dea: [X86][Costmodel] `trunc v8i64 to v16i8/v32i8/v64i8` can appear after…

Summary

While this one is trivial and identical to the previous patch,
there is a weird cost change in a follow-up patch that i'm not sure about.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

lebedev.ri created this revision.Nov 14 2021, 10:08 AM

Herald added subscribers: pengfei, hiraditya. · View Herald TranscriptNov 14 2021, 10:08 AM

lebedev.ri requested review of this revision.Nov 14 2021, 10:08 AM

lebedev.ri added a parent revision: D113850: [X86][Costmodel] `trunc v16i32 to v32i8/v64i8` can appear after legalization, cost is same as for `trunc v16i32 to v16i8`.

lebedev.ri added a child revision: D113852: [X86][Costmodel] `trunc v32i16 to v64i8` can appear after legalization, cost is same as for `trunc v32i16 to v32i8`.

Harbormaster completed remote builds in B134150: Diff 387105.Nov 14 2021, 11:07 AM

LGTM

This revision is now accepted and ready to land.Nov 15 2021, 7:35 AM

In D113851#3131552, @RKSimon wrote:

LGTM

Thank you for the review!

This revision was landed with ongoing or failed builds.Nov 15 2021, 8:04 AM

Closed by commit rG9e57d9b09dea: [X86][Costmodel] `trunc v8i64 to v16i8/v32i8/v64i8` can appear after… (authored by lebedev.ri). · Explain Why

This revision was automatically updated to reflect the committed changes.

lebedev.ri added a commit: rG9e57d9b09dea: [X86][Costmodel] `trunc v8i64 to v16i8/v32i8/v64i8` can appear after….

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

X86/

X86TargetTransformInfo.cpp

3 lines

test/

Analysis/

CostModel/

X86/

trunc.ll

112 lines

Diff 387105

View Options

llvm/lib/Target/X86/X86TargetTransformInfo.cpp