This is an archive of the discontinued LLVM Phabricator instance.

Xfail TestGdbRemoteAbort for Android API <= 16.
ClosedPublic

Authored by chaoren on Jul 20 2015, 5:58 PM.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 30224.Jul 20 2015, 5:58 PM
chaoren retitled this revision from to Xfail TestGdbRemoteAbort for Android API <= 16..
chaoren updated this object.
chaoren added a reviewer: sivachandra.
chaoren added a subscriber: lldb-commits.
tberghammer added inline comments.Jul 21 2015, 2:29 AM
test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
36–37
  • For me "abort() below API 16 raises SIGSEGV" means it already works on API-16, but the XFAIL range specifies it isn't. Can you clarify it? (If I misunderstand the comment then please ignore this.)
  • Even though we most likely never run the test suit against API level less then 9 I think it is cleaner if you specify the XFAIL for API range [1, 16] (or range [0, 16])
chaoren updated this revision to Diff 30269.Jul 21 2015, 10:37 AM

Address review.

sivachandra accepted this revision.Jul 21 2015, 10:42 AM
sivachandra edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2015, 10:42 AM
This revision was automatically updated to reflect the committed changes.