Page MenuHomePhabricator

chaoren (Chaoren Lin)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2014, 11:12 AM (264 w, 2 d)

Recent Activity

Apr 20 2017

chaoren removed a reviewer for D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm: chaoren.
Apr 20 2017, 8:16 AM

Sep 7 2016

chaoren added a comment to D24293: Use llvm's demangler.

Cool. Would it be a good idea to only use LLVM's demangler? We can get rid of all the messy ifdef business, and I assume the LLVM demangler would be better maintained and more up to date than any system demangler.

Sep 7 2016, 8:35 AM

Jul 18 2016

chaoren committed rL275914: Add missing headers after header cleanup in r275882..
Add missing headers after header cleanup in r275882.
Jul 18 2016, 2:19 PM

May 23 2016

chaoren committed rL270493: Make sure TestRedefinitionsInInlines.py actually inlines..
Make sure TestRedefinitionsInInlines.py actually inlines.
May 23 2016, 2:51 PM
chaoren closed D20540: Make sure TestRedefinitionsInInlines.py actually inlines. by committing rL270493: Make sure TestRedefinitionsInInlines.py actually inlines..
May 23 2016, 2:51 PM
chaoren retitled D20540: Make sure TestRedefinitionsInInlines.py actually inlines. from Make sure TestRedefinitionsInInlines.py always actually inlines. to Make sure TestRedefinitionsInInlines.py actually inlines..
May 23 2016, 2:49 PM
chaoren retitled D20540: Make sure TestRedefinitionsInInlines.py actually inlines. from to Make sure TestRedefinitionsInInlines.py always actually inlines..
May 23 2016, 2:48 PM

May 4 2016

chaoren added a comment to D19751: Fix TestEnumTypes.py for 32 bit platforms..

We don't test host-only Windows. It's passing Windows to Android though.
What's the reason that it fails on Windows?

May 4 2016, 3:02 PM

Apr 29 2016

chaoren committed rL268135: Fix TestEnumTypes.py for 32 bit platforms..
Fix TestEnumTypes.py for 32 bit platforms.
Apr 29 2016, 4:40 PM
chaoren closed D19751: Fix TestEnumTypes.py for 32 bit platforms. by committing rL268135: Fix TestEnumTypes.py for 32 bit platforms..
Apr 29 2016, 4:40 PM
chaoren retitled D19751: Fix TestEnumTypes.py for 32 bit platforms. from to Fix TestEnumTypes.py for 32 bit platforms..
Apr 29 2016, 4:39 PM

Apr 28 2016

chaoren committed rL267923: XFail TestBitfields.py Python API tests..
XFail TestBitfields.py Python API tests.
Apr 28 2016, 12:46 PM
chaoren closed D19680: XFail TestBitfields.py Python API tests. by committing rL267923: XFail TestBitfields.py Python API tests..
Apr 28 2016, 12:46 PM
chaoren updated D19680: XFail TestBitfields.py Python API tests..
Apr 28 2016, 12:45 PM
chaoren updated the diff for D19680: XFail TestBitfields.py Python API tests..

Clickable links.

Apr 28 2016, 12:44 PM
chaoren retitled D19680: XFail TestBitfields.py Python API tests. from to XFail TestBitfields.py Python API tests..
Apr 28 2016, 12:43 PM

Apr 27 2016

chaoren committed rL267829: Use llvm:Twine instead of std::to_string..
Use llvm:Twine instead of std::to_string.
Apr 27 2016, 5:55 PM
chaoren closed D19638: Use llvm:Twine instead of std::to_string. by committing rL267829: Use llvm:Twine instead of std::to_string..
Apr 27 2016, 5:55 PM
chaoren updated the diff for D19638: Use llvm:Twine instead of std::to_string..

Add reason.

Apr 27 2016, 4:08 PM
chaoren retitled D19638: Use llvm:Twine instead of std::to_string. from to Use llvm:Twine instead of std::to_string..
Apr 27 2016, 3:50 PM

Apr 25 2016

chaoren committed rL267492: Fix TestGetVariables.py..
Fix TestGetVariables.py.
Apr 25 2016, 4:35 PM
chaoren closed D19511: Fix TestGetVariables.py. by committing rL267492: Fix TestGetVariables.py..
Apr 25 2016, 4:35 PM
chaoren retitled D19511: Fix TestGetVariables.py. from to Fix TestGetVariables.py..
Apr 25 2016, 4:21 PM

Apr 20 2016

chaoren committed rL266925: [Tooling] Fix getting fully qualified names of template alias types..
[Tooling] Fix getting fully qualified names of template alias types.
Apr 20 2016, 3:18 PM
chaoren closed D19253: [Tooling] Fix getting fully qualified names of template alias types. by committing rL266925: [Tooling] Fix getting fully qualified names of template alias types..
Apr 20 2016, 3:17 PM

Apr 18 2016

chaoren committed rL266702: Fix Windows build..
Fix Windows build.
Apr 18 2016, 6:15 PM

Mar 25 2016

chaoren added a comment to D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm.

This seems very strange to me. What if someone specifies those flags on the command line in the makefile instead of via some environment variables?

Mar 25 2016, 1:48 PM

Mar 17 2016

chaoren committed rL263766: Remove usage of LLVM_PREFIX..
Remove usage of LLVM_PREFIX.
Mar 17 2016, 5:10 PM
chaoren closed D17784: Check if LLVM_PREFIX is defined before using it. by committing rL263766: Remove usage of LLVM_PREFIX..
Mar 17 2016, 5:10 PM
chaoren updated the diff for D17784: Check if LLVM_PREFIX is defined before using it..

Remove usage of LLVM_PREFIX altogether.

Mar 17 2016, 5:08 PM

Mar 14 2016

chaoren accepted D17402: Shuffle an #undef to avoid a warning on FreeBSD.

Seems legit.

Mar 14 2016, 1:32 PM

Mar 2 2016

chaoren added a reviewer for D17784: Check if LLVM_PREFIX is defined before using it.: chandlerc.
Mar 2 2016, 3:58 PM

Mar 1 2016

chaoren retitled D17784: Check if LLVM_PREFIX is defined before using it. from to Check if LLVM_PREFIX is defined before using it..
Mar 1 2016, 3:00 PM

Feb 26 2016

chaoren committed rL262081: Register value is not necessarily scalar..
Register value is not necessarily scalar.
Feb 26 2016, 2:17 PM
chaoren closed D17658: Register value is not necessarily scalar. by committing rL262081: Register value is not necessarily scalar..
Feb 26 2016, 2:17 PM
chaoren updated the diff for D17658: Register value is not necessarily scalar..

Check return value of GetScalarValue directly.

Feb 26 2016, 2:13 PM
chaoren retitled D17658: Register value is not necessarily scalar. from to Register value is not necessarily scalar..
Feb 26 2016, 2:11 PM

Feb 25 2016

chaoren committed rL261969: Clear alias argument vector for 'p' alias..
Clear alias argument vector for 'p' alias.
Feb 25 2016, 7:41 PM
chaoren closed D17634: Clear alias argument vector for 'p' alias. by committing rL261969: Clear alias argument vector for 'p' alias..
Feb 25 2016, 7:41 PM
chaoren retitled D17634: Clear alias argument vector for 'p' alias. from to Clear alias argument vector for 'p' alias..
Feb 25 2016, 7:40 PM

Feb 23 2016

chaoren committed rL261718: Fix TestCStrings for Linux with i386 inferiors..
Fix TestCStrings for Linux with i386 inferiors.
Feb 23 2016, 7:36 PM
chaoren closed D17557: Fix TestCStrings for Linux with i386 inferiors. by committing rL261718: Fix TestCStrings for Linux with i386 inferiors..
Feb 23 2016, 7:28 PM
chaoren updated the diff for D17557: Fix TestCStrings for Linux with i386 inferiors..

Use target instead of sc.target_sp.get().

Feb 23 2016, 5:47 PM
chaoren retitled D17557: Fix TestCStrings for Linux with i386 inferiors. from to Fix TestCStrings for Linux with i386 inferiors..
Feb 23 2016, 5:44 PM

Jan 28 2016

chaoren committed rL259153: Fix TestDataFormatterScript for Linux..
Fix TestDataFormatterScript for Linux.
Jan 28 2016, 7:52 PM
chaoren closed D16703: Fix TestDataFormatterScript for Linux. by committing rL259153: Fix TestDataFormatterScript for Linux..
Jan 28 2016, 7:52 PM
chaoren retitled D16703: Fix TestDataFormatterScript for Linux. from to Fix TestDataFormatterScript for Linux..
Jan 28 2016, 6:37 PM
chaoren added inline comments to rL259131: Fix a bug where LLDB would not print the name of the function that a scripted….
Jan 28 2016, 6:33 PM
chaoren added inline comments to rL259117: [CodeView] Use assembler directives for line tables.
Jan 28 2016, 3:59 PM
chaoren committed rL259086: Fix build after rL259070..
Fix build after rL259070.
Jan 28 2016, 12:30 PM

Nov 6 2015

chaoren committed rL252391: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355..
Fix TestThreadSpecificBreakpoint.py on Linux after rL252355.
Nov 6 2015, 6:18 PM
chaoren closed D14472: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355. by committing rL252391: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355..
Nov 6 2015, 6:18 PM
chaoren retitled D14472: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355. from to Fix TestThreadSpecificBreakpoint.py on Linux after rL252355..
Nov 6 2015, 6:07 PM
chaoren added a comment to rL252355: Another optimization to keep down gdb-remote traffic. If we have suspended a….

I'm still not quite sure how this works, but changing:

Nov 6 2015, 5:20 PM
chaoren added a comment to rL252355: Another optimization to keep down gdb-remote traffic. If we have suspended a….

Hi, do you think this could have affected thread specific breakpoints? It seems a bit suspicious that TestThreadSpecificBreakpoints.py started timing out completely after this change and rL252356.

Nov 6 2015, 3:41 PM
chaoren committed rL252353: Fix Linux tests after r252348..
Fix Linux tests after r252348.
Nov 6 2015, 2:33 PM

Nov 5 2015

chaoren committed rL252230: Another import fix for OS X..
Another import fix for OS X.
Nov 5 2015, 3:21 PM
chaoren committed rL252218: Fix OS X tests..
Fix OS X tests.
Nov 5 2015, 2:03 PM
chaoren committed rL252205: Completely avoid building Apple simulator on non-Darwin platforms..
Completely avoid building Apple simulator on non-Darwin platforms.
Nov 5 2015, 12:47 PM
chaoren closed D14389: Completely avoid building Apple simulator on non-Darwin platforms. by committing rL252205: Completely avoid building Apple simulator on non-Darwin platforms..
Nov 5 2015, 12:47 PM
chaoren added a comment to D14389: Completely avoid building Apple simulator on non-Darwin platforms..

I haven't seen anything else that uses LLVM_OPTIONAL_SOURCES, but it's conceivable that there might be items in the list already, and I would like to avoid doing anything to it besides just appending.

Nov 5 2015, 12:29 PM
chaoren added a comment to D14389: Completely avoid building Apple simulator on non-Darwin platforms..

It's not actually CMake complaining but the LLVM cmake scripts.

Nov 5 2015, 12:23 PM
chaoren added a comment to D14389: Completely avoid building Apple simulator on non-Darwin platforms..

LLVM_OPTIONAL_SOURCES should avoid that.

Nov 5 2015, 12:22 PM
chaoren retitled D14389: Completely avoid building Apple simulator on non-Darwin platforms. from to Completely avoid building Apple simulator on non-Darwin platforms..
Nov 5 2015, 12:19 PM
chaoren accepted rL252179: Do not build any of the simulator material on non-Darwin.

I've reverted this change to get the builders running again. Hope you don't mind.

Nov 5 2015, 10:52 AM
chaoren committed rL252183: Use lldb::pid_t instead of pid_t..
Use lldb::pid_t instead of pid_t.
Nov 5 2015, 10:51 AM
chaoren committed rL252182: Revert "Do not build any of the simulator material on non-Darwin".
Revert "Do not build any of the simulator material on non-Darwin"
Nov 5 2015, 10:51 AM
chaoren closed D14388: Use lldb::pid_t instead of pid_t. by committing rL252183: Use lldb::pid_t instead of pid_t..
Nov 5 2015, 10:51 AM
chaoren raised a concern with rL252179: Do not build any of the simulator material on non-Darwin.

The LLVM cmake project doesn't like having cpp files lying around that don't get used. So this actually breaks the build on all non-darwin systems.

Nov 5 2015, 10:43 AM
chaoren retitled D14388: Use lldb::pid_t instead of pid_t. from to Use lldb::pid_t instead of pid_t..
Nov 5 2015, 10:39 AM

Nov 4 2015

chaoren committed rL252143: Fix build for platforms without ObjC++..
Fix build for platforms without ObjC++.
Nov 4 2015, 7:33 PM
chaoren closed D14365: Fix build for platforms without ObjC++. by committing rL252143: Fix build for platforms without ObjC++..
Nov 4 2015, 7:33 PM
chaoren retitled D14365: Fix build for platforms without ObjC++. from to Fix build for platforms without ObjC++..
Nov 4 2015, 6:34 PM
chaoren committed rL252133: Fix TestGoFormatters.py..
Fix TestGoFormatters.py.
Nov 4 2015, 6:19 PM
chaoren added a comment to D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..

Yeah, it seems like it's been passing for gcc-4.9 for a while now. Thanks
for checking!

Nov 4 2015, 6:02 PM
chaoren accepted rL252112: Teach LLDB how to directly launch processes on the iOS simulator.

Fixed with http://reviews.llvm.org/rL252124

Nov 4 2015, 5:27 PM
chaoren committed rL252124: Fix build on Linux..
Fix build on Linux.
Nov 4 2015, 5:25 PM
chaoren raised a concern with rL252112: Teach LLDB how to directly launch processes on the iOS simulator.

Hi, this breaks all of our linux builders:

Nov 4 2015, 5:22 PM

Oct 28 2015

chaoren committed rL251589: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR..
Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR.
Oct 28 2015, 5:51 PM
chaoren closed D14166: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR. by committing rL251589: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR..
Oct 28 2015, 5:51 PM
chaoren resigned from D13819: LLDBStandalone: Report nice errors on missing vars.

Seems legit. But I've never built standalone, so I probably shouldn't be a reviewer for this.

Oct 28 2015, 5:42 PM
chaoren retitled D14166: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR. from to Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR..
Oct 28 2015, 5:39 PM

Oct 27 2015

chaoren committed rL251439: Use accept4 workaround for MIPS Android build..
Use accept4 workaround for MIPS Android build.
Oct 27 2015, 12:19 PM
chaoren closed D14127: Use accept4 workaround for MIPS Android build. by committing rL251439: Use accept4 workaround for MIPS Android build..
Oct 27 2015, 12:19 PM
chaoren retitled D14127: Use accept4 workaround for MIPS Android build. from to Use accept4 workaround for MIPS Android build..
Oct 27 2015, 12:14 PM

Oct 6 2015

chaoren committed rL249486: Fix Android build..
Fix Android build.
Oct 6 2015, 5:03 PM

Sep 22 2015

chaoren committed rL248301: Update TestChangeProcessGroup to remove obsolete workaround..
Update TestChangeProcessGroup to remove obsolete workaround.
Sep 22 2015, 10:39 AM
chaoren closed D12976: Update TestChangeProcessGroup to remove obsolete workaround. by committing rL248301: Update TestChangeProcessGroup to remove obsolete workaround..
Sep 22 2015, 10:39 AM

Sep 21 2015

chaoren retitled D12976: Update TestChangeProcessGroup to remove obsolete workaround. from Fix TestChangeProcessGroup to properly step out of sleep. to Update TestChangeProcessGroup to remove obsolete workaround..
Sep 21 2015, 1:58 PM
chaoren updated the diff for D12976: Update TestChangeProcessGroup to remove obsolete workaround..

Remove existing workaround.

Sep 21 2015, 1:58 PM
chaoren added a comment to D12976: Update TestChangeProcessGroup to remove obsolete workaround..

Do we still need the original stepInstruction?

Sep 21 2015, 9:41 AM

Sep 18 2015

chaoren accepted rL248072: Added a curses based way to see the test suite running. Works only where….

Fixed http://reviews.llvm.org/rL248075

Sep 18 2015, 5:59 PM
chaoren committed rL248075: Fix Linux bot..
Fix Linux bot.
Sep 18 2015, 5:58 PM
chaoren raised a concern with rL248072: Added a curses based way to see the test suite running. Works only where….
Sep 18 2015, 5:54 PM
chaoren added a comment to D12976: Update TestChangeProcessGroup to remove obsolete workaround..

I thought this was supposed to be fixed, but TestChangeProcessGroup, TestExpressionInSyscall, and TestRegisters just started failing for me recently because of this.

Sep 18 2015, 11:01 AM
chaoren updated the diff for D12976: Update TestChangeProcessGroup to remove obsolete workaround..

Remove old line.

Sep 18 2015, 11:00 AM
chaoren retitled D12976: Update TestChangeProcessGroup to remove obsolete workaround. from to Fix TestChangeProcessGroup to properly step out of sleep..
Sep 18 2015, 10:33 AM

Sep 17 2015

chaoren committed rL247914: Fix TestMiSymbol for gcc-4.9 test..
Fix TestMiSymbol for gcc-4.9 test.
Sep 17 2015, 11:40 AM
chaoren added a comment to D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..

Could you please take a look at these issues?

Sep 17 2015, 10:30 AM

Sep 16 2015

chaoren committed rL247863: XFAIL TestCppNsImport for gcc-4.9 inclusive..
XFAIL TestCppNsImport for gcc-4.9 inclusive.
Sep 16 2015, 4:38 PM