This is an archive of the discontinued LLVM Phabricator instance.

Xfail TestGdbRemoteAbort for Android API <= 16.
ClosedPublic

Authored by chaoren on Jul 20 2015, 5:58 PM.

Reviewers

Commits

chaoren retitled this revision from to Xfail TestGdbRemoteAbort for Android API <= 16..

chaoren updated this object.

chaoren added a reviewer: sivachandra.

chaoren added a subscriber: lldb-commits.

test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
36	For me "abort() below API 16 raises SIGSEGV" means it already works on API-16, but the XFAIL range specifies it isn't. Can you clarify it? (If I misunderstand the comment then please ignore this.) Even though we most likely never run the test suit against API level less then 9 I think it is cleaner if you specify the XFAIL for API range [1, 16] (or range [0, 16])

Address review.

sivachandra edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2015, 10:42 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

tools/

lldb-server/

inferior-crash/

2 lines

Show All 27 Lines	class TestGdbRemoteAbort(gdbremote_testcase.GdbRemoteTestCaseBase):
@dsym_test		@dsym_test
def test_inferior_abort_received_debugserver_dsym(self):		def test_inferior_abort_received_debugserver_dsym(self):
self.init_debugserver_test()		self.init_debugserver_test()
self.buildDsym()		self.buildDsym()
self.inferior_abort_received()		self.inferior_abort_received()

@llgs_test		@llgs_test
@dwarf_test		@dwarf_test
@skipIfTargetAndroid(api_levels=[16]) # abort() on API 16 raises SIGSEGV!		@expectedFailureAndroid(api_levels=range(9, 16 + 1)) # abort() below API 16 raises SIGSEGV!
		tberghammerUnsubmitted Not Done Reply Inline Actions For me "abort() below API 16 raises SIGSEGV" means it already works on API-16, but the XFAIL range specifies it isn't. Can you clarify it? (If I misunderstand the comment then please ignore this.) Even though we most likely never run the test suit against API level less then 9 I think it is cleaner if you specify the XFAIL for API range [1, 16] (or range [0, 16]) tberghammer: * For me "abort() below API 16 raises SIGSEGV" means it already works on API-16, but the XFAIL…
def test_inferior_abort_received_llgs_dwarf(self):		def test_inferior_abort_received_llgs_dwarf(self):
self.init_llgs_test()		self.init_llgs_test()
self.buildDwarf()		self.buildDwarf()
self.inferior_abort_received()		self.inferior_abort_received()