This is an archive of the discontinued LLVM Phabricator instance.

Differential D113729

[Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows
ClosedPublic

Authored by phosek on Nov 11 2021, 7:26 PM.

Details

Reviewers
haowei
Commits
rG8df26e7b4aea: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows
Summary

We don't build libcxxabi and libunwind for Windows so don't set the
corresponding variables to avoid configuration errors.

Diff Detail

Event Timeline

phosek created this revision.Nov 11 2021, 7:26 PM
Herald added subscribers: abrachet, mgorny. · View Herald TranscriptNov 11 2021, 7:26 PM
phosek requested review of this revision.Nov 11 2021, 7:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2021, 7:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
haowei accepted this revision.Nov 11 2021, 7:28 PM
This revision is now accepted and ready to land.Nov 11 2021, 7:28 PM
This revision was landed with ongoing or failed builds.Nov 11 2021, 7:29 PM
Closed by commit rG8df26e7b4aea: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG8df26e7b4aea: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows.
Harbormaster completed remote builds in B133859: Diff 386717.Nov 11 2021, 8:15 PM

Revision Contents

PathSize
clang/
cmake/
caches/
24 lines

Diff 386719

clang/cmake/caches/Fuchsia.cmake

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
endif() endif()
if(APPLE) if(APPLE)
set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "")
endif() endif()
if(WIN32)
set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(BUILTINS_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(RUNTIMES_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "")
else()
set(LIBUNWIND_ENABLE_SHARED OFF CACHE BOOL "") set(LIBUNWIND_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBUNWIND_INSTALL_LIBRARY OFF CACHE BOOL "") set(LIBUNWIND_INSTALL_LIBRARY OFF CACHE BOOL "")
set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "") set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "")
set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "")
set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_ABI_VERSION 2 CACHE STRING "") set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
if(WIN32)
set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY OFF CACHE BOOL "")
set(BUILTINS_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(RUNTIMES_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "")
else()
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "") set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
endif() endif()
if(BOOTSTRAP_CMAKE_SYSTEM_NAME) if(BOOTSTRAP_CMAKE_SYSTEM_NAME)
set(target "${BOOTSTRAP_CMAKE_CXX_COMPILER_TARGET}") set(target "${BOOTSTRAP_CMAKE_CXX_COMPILER_TARGET}")
if(STAGE2_LINUX_${target}_SYSROOT) if(STAGE2_LINUX_${target}_SYSROOT)
set(LLVM_BUILTIN_TARGETS "${target}" CACHE STRING "") set(LLVM_BUILTIN_TARGETS "${target}" CACHE STRING "")
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines