This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Tweak whitespace in LiveInterval printing
ClosedPublic

Authored by foad on Nov 11 2021, 6:24 AM.

Details

Summary

When printing a LiveInterval, tweak the use of single and double spaces
to try to make it clearer that the valnos are associated with the
preceding range or subrange, not the following subrange.

Compare the output before and then after this patch:
%1 [32r,144r:0) 0@32r L000000000000000C [32r,144r:0) 0@32r L00000000000000F3 [32r,32d:0) 0@32r weight:0.000000e+00
%1 [32r,144r:0) 0@32r L000000000000000C [32r,144r:0) 0@32r L00000000000000F3 [32r,32d:0) 0@32r weight:0.000000e+00

Diff Detail

Event Timeline

foad created this revision.Nov 11 2021, 6:24 AM
foad requested review of this revision.Nov 11 2021, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2021, 6:25 AM
arsenm accepted this revision.Nov 11 2021, 6:30 AM

I don't see the difference in the example, but maybe phabricator just ate the whitespace differences

llvm/lib/CodeGen/LiveInterval.cpp
1023

Single quotes now

This revision is now accepted and ready to land.Nov 11 2021, 6:30 AM
foad added a comment.Nov 11 2021, 6:36 AM

I don't see the difference in the example, but maybe phabricator just ate the whitespace differences

The Edit Revision button in the web UI will show it to you with full whitespace.

foad updated this revision to Diff 386502.Nov 11 2021, 6:46 AM

Single quotes.

arsenm accepted this revision.Nov 11 2021, 6:57 AM
This revision was landed with ongoing or failed builds.Nov 11 2021, 7:20 AM
This revision was automatically updated to reflect the committed changes.