This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Mark a failing test.
ClosedPublic

Authored by Mordante on Nov 3 2021, 1:12 PM.

Details

Reviewers
ldionne
Quuxplusone
Group Reviewers
Restricted Project
Commits
rGa948a0a23ce7: [libc++] Mark a failing test.
Summary

The tests fails in debug mode since it manipulates an iterator to a
std::string returned from the dylib. This is a known issue for the
debug iterators.

Updating the libc++ Docker image to Ubuntu Focal caused some breakage.
This was temporary disabled in D112737. This re-enables one of these
tests.

Diff Detail

Event Timeline

Mordante requested review of this revision.Nov 3 2021, 1:12 PM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2021, 1:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone added a subscriber: Quuxplusone.

it manipulates an iterator to a std::string returned from the dylib

It would be nice to say in the commit message which dylib function is the culprit, and where in this 600-line test the iterator is being manipulated. (I'm aware of std::to_string(int) as a frequent culprit; I just don't know if that's the dylib function you're talking about in this specific case.)

Mordante updated this revision to Diff 384796.Nov 4 2021, 9:59 AM

Disable the test for gcc-11. It seems GCC has an issue with template argument
deduction. The code affected follows the wording of the Standard. This will be
investigated later.
Add more information regarding the other disabled test.

it manipulates an iterator to a std::string returned from the dylib

It would be nice to say in the commit message which dylib function is the culprit, and where in this 600-line test the iterator is being manipulated. (I'm aware of std::to_string(int) as a frequent culprit; I just don't know if that's the dylib function you're talking about in this specific case.)

It's numpunct's grouping and the issue is in <format> not in the test itself. I've added this information in the test.

ldionne accepted this revision.Nov 8 2021, 1:53 PM
This revision is now accepted and ready to land.Nov 8 2021, 1:53 PM
This revision was automatically updated to reflect the committed changes.