This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Temporarily mark tests as UNSUPPORTED to get the CI green
ClosedPublic

Authored by ldionne on Oct 28 2021, 10:58 AM.

Details

Reviewers
Mordante
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rGa55632a069d8: [libc++] Temporarily mark tests as UNSUPPORTED to get the CI green
Summary

After recent changes to the Docker image, all hell broke loose and the
CI started failing. This patch marks a few tests as unsupported until
we can figure out what the issues are and fix them.

In the future, it would be ideal if the nodes could pick up the Dockerfile
present in the revision being tested, which would allow us to test changes
to the Dockerfile in the CI, like we do for all other code changes.

Diff Detail

Event Timeline

ldionne requested review of this revision.Oct 28 2021, 10:58 AM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 10:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jloser added a subscriber: jloser.Oct 28 2021, 11:04 AM
jloser added inline comments.
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
17

Can we just XFAIL them for gcc11 instead for now? Ditto for the other uses.

Mordante accepted this revision as: Mordante.Oct 28 2021, 11:06 AM

Thanks for addressing these issues! LGTM!

ldionne updated this revision to Diff 383089.Oct 28 2021, 11:06 AM

Correct invalid UNSUPPORTED markup.

ldionne marked an inline comment as done.Oct 28 2021, 11:11 AM
ldionne added inline comments.
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
17

No, these tests fail in various circumstances like ASAN on Clang 14, Debug iterators and other jobs. Since this is ultra temporary, I'm fine with using a coarse grained UNSUPPORTED.

jloser added inline comments.Oct 28 2021, 11:14 AM
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
17

Got it, thanks for the explanation.

Mordante added inline comments.Oct 28 2021, 11:15 AM
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
17

Normally I agree with this sentiment. But my change accidentally broke the entire CI. So I prefer this work-around and then fix it properly afterwards. That way we can keep using our CI while we sort the fallout later.

It seems updating the Dockerfile in a commit doesn't cause the CI to use these changes.

ldionne updated this revision to Diff 383102.Oct 28 2021, 11:27 AM
ldionne marked an inline comment as done.

Remove XFAIL for libunwind test on GCC. Frankly I don't know why it passes suddenly.

Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 11:27 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 383124.Oct 28 2021, 12:38 PM

Add a ton of UNSUPPORTED on the 32 bits job. For some reason they fail with something I can't even reproduce locally in the same Docker image.

ldionne updated this revision to Diff 383141.Oct 28 2021, 1:17 PM

Fix libc++abi issue on 32 bits. Should be all good if libunwind passes.

I've said it before, but I can't reproduce any of these 32-bit issues on a Docker image locally, which is quite weird.

Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 1:17 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: arichardson. · View Herald Transcript
ldionne updated this revision to Diff 383145.Oct 28 2021, 1:30 PM

Everything should pass now, shipping.

ldionne accepted this revision.Oct 28 2021, 1:30 PM
This revision is now accepted and ready to land.Oct 28 2021, 1:30 PM
This revision was landed with ongoing or failed builds.Oct 28 2021, 1:30 PM
This revision was automatically updated to reflect the committed changes.