This is an archive of the discontinued LLVM Phabricator instance.

Differential D113064

[llvm-profdata] Print out section flags for FunctionMetadata section
ClosedPublic

Authored by hoy on Nov 2 2021, 3:12 PM.

Details

Reviewers
wenlei
wlei
rajeshwarv
Commits
rGd0eb472f334b: [llvm-profdata] Print out section flags for FunctionMetadata section
Summary

As titled.

Diff Detail

Event Timeline

hoy created this revision.Nov 2 2021, 3:12 PM
Herald added subscribers: modimo, wenlei, hiraditya. · View Herald TranscriptNov 2 2021, 3:12 PM
hoy requested review of this revision.Nov 2 2021, 3:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 3:12 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
hoy edited the summary of this revision. (Show Details)Nov 2 2021, 3:13 PM
hoy added reviewers: wenlei, wlei, rajeshwarv.
wlei accepted this revision.Nov 2 2021, 3:36 PM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 2 2021, 3:36 PM
Harbormaster completed remote builds in B132085: Diff 384255.Nov 2 2021, 3:56 PM
wenlei accepted this revision.Nov 2 2021, 4:01 PM

lgtm, thanks.

Closed by commit rGd0eb472f334b: [llvm-profdata] Print out section flags for FunctionMetadata section (authored by hoy). · Explain WhyNov 2 2021, 5:59 PM
This revision was automatically updated to reflect the committed changes.
hoy added a commit: rGd0eb472f334b: [llvm-profdata] Print out section flags for FunctionMetadata section.

Revision Contents

PathSize
llvm/
lib/
ProfileData/
6 lines
test/
tools/
llvm-profdata/
2 lines
3 lines

Diff 384294

llvm/lib/ProfileData/SampleProfReader.cpp

Show First 20 Lines • Show All 1,222 Lines • ▼ Show 20 Lines if (hasSecFlag(Entry, SecProfSummaryFlags::SecFlagFullContext))
Flags.append("context,"); Flags.append("context,");
if (hasSecFlag(Entry, SecProfSummaryFlags::SecFlagFSDiscriminator)) if (hasSecFlag(Entry, SecProfSummaryFlags::SecFlagFSDiscriminator))
Flags.append("fs-discriminator,"); Flags.append("fs-discriminator,");
break; break;
case SecFuncOffsetTable: case SecFuncOffsetTable:
if (hasSecFlag(Entry, SecFuncOffsetFlags::SecFlagOrdered)) if (hasSecFlag(Entry, SecFuncOffsetFlags::SecFlagOrdered))
Flags.append("ordered,"); Flags.append("ordered,");
break; break;
case SecFuncMetadata:
if (hasSecFlag(Entry, SecFuncMetadataFlags::SecFlagIsProbeBased))
Flags.append("probe,");
if (hasSecFlag(Entry, SecFuncMetadataFlags::SecFlagHasAttribute))
Flags.append("attr,");
break;
default: default:
break; break;
} }
char &last = Flags.back(); char &last = Flags.back();
if (last == ',') if (last == ',')
last = '}'; last = '}';
else else
Flags.append("}"); Flags.append("}");
▲ Show 20 Lines • Show All 600 Lines • Show Last 20 Lines

llvm/test/tools/llvm-profdata/cs-sample-profile.test

RUN: llvm-profdata merge --sample --text -output=%t.proftext %S/Inputs/cs-sample.proftext RUN: llvm-profdata merge --sample --text -output=%t.proftext %S/Inputs/cs-sample.proftext
RUN: diff -b %t.proftext %S/Inputs/cs-sample.proftext RUN: diff -b %t.proftext %S/Inputs/cs-sample.proftext
RUN: llvm-profdata merge --sample --extbinary %p/Inputs/cs-sample.proftext -o %t.prof && llvm-profdata merge --sample --text %t.prof -o %t1.proftext RUN: llvm-profdata merge --sample --extbinary %p/Inputs/cs-sample.proftext -o %t.prof && llvm-profdata merge --sample --text %t.prof -o %t1.proftext
RUN: diff -b %t1.proftext %S/Inputs/cs-sample.proftext RUN: diff -b %t1.proftext %S/Inputs/cs-sample.proftext
RUN: llvm-profdata show --sample -show-sec-info-only %t.prof | FileCheck %s
CHECK: FunctionMetadata {{.*}} Flags: {attr}

llvm/test/tools/llvm-profdata/merge-probe-profile.test

Show All 16 Lines
MERGE2: foo:6400:26 MERGE2: foo:6400:26
MERGE2: 1: 26 MERGE2: 1: 26
MERGE2: 2: 14 MERGE2: 2: 14
MERGE2: 3: 18446744073709551615 MERGE2: 3: 18446744073709551615
MERGE2: 4: 26 MERGE2: 4: 26
MERGE2: 5: 14 _Z3foov:10 _Z3barv:4 MERGE2: 5: 14 _Z3foov:10 _Z3barv:4
MERGE2: 6: 12 _Z3barv:8 _Z3foov:4 MERGE2: 6: 12 _Z3barv:8 _Z3foov:4
MERGE2: !CFGChecksum: 563022570642068 MERGE2: !CFGChecksum: 563022570642068
RUN: llvm-profdata show --sample -show-sec-info-only %t | FileCheck %s
CHECK: FunctionMetadata {{.*}} Flags: {probe}
No newline at end of file