This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] Write -v output to stderr
ClosedPublic

Authored by thakis on Nov 2 2021, 7:15 AM.

Details

Reviewers
MaskRay
gkm
oontvoo
Group Reviewers
Restricted Project
Commits
rG64c173443825: [lld/mac] Write -v output to stderr
Summary

This matches ld64, and it's conceivable that projects try to read
this information off stderr for that reason.

--version keeps writing to stdout.

Diff Detail

Event Timeline

thakis created this revision.Nov 2 2021, 7:15 AM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Nov 2 2021, 7:15 AM
thakis added a comment.Nov 2 2021, 7:42 AM

(The OR in D113021 is needed because current LLD doesn't do this yet)

oontvoo accepted this revision.Nov 2 2021, 8:20 AM
oontvoo added a subscriber: oontvoo.

LGTM

(a bit of an interesting behaviour on LD64 - but then I'd expect nothing less from it ...)

lld/MachO/Driver.cpp
1365

test failures look related - (ie., tests need to read stderr: 2>&1 ?)

This revision is now accepted and ready to land.Nov 2 2021, 8:20 AM
This revision was landed with ongoing or failed builds.Nov 2 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 10:59 AM