This is an archive of the discontinued LLVM Phabricator instance.

Differential D112964

[WebAssembly] Disable test that doesn't work on Windows
Needs ReviewPublic

Authored by aardappel on Nov 1 2021, 2:46 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

aardappel created this revision.Nov 1 2021, 2:46 PM
Herald added subscribers: ormris, wingo, ecnelises and 5 others. · View Herald TranscriptNov 1 2021, 2:46 PM
aardappel requested review of this revision.Nov 1 2021, 2:46 PM
Herald added a subscriber: aheejin. · View Herald TranscriptNov 1 2021, 2:46 PM
sbc100 added inline comments.Nov 1 2021, 3:03 PM
lld/test/wasm/lto/thinlto-thin-archive-collision.ll
3

Why doesn't this test run on windows? Can we fix it instead?

Why haven't others complained about this do you think?

Harbormaster completed remote builds in B131816: Diff 383895.Nov 1 2021, 3:03 PM
sbc100 added inline comments.Nov 1 2021, 3:05 PM
lld/test/wasm/lto/thinlto-thin-archive-collision.ll
3

This test was copied directly from lld/test/ELF/lto/thinlto-thin-archive-collision.ll .. which doesn't seem to be disabled on windows, so I wonder what is going on here that is different?

aardappel added inline comments.Nov 1 2021, 3:34 PM
lld/test/wasm/lto/thinlto-thin-archive-collision.ll
3

It fails with

failed to open thinlto-archives/thin.aa/thin.o.0.preopt.bc: no such file or directory
failed to open thinlto-archives/thin.ab/thin.o.0.preopt.bc: no such file or directory

Is there maybe something about the script that is bash specific? It's running thru llvm-lit on powershell.

aardappel added inline comments.Nov 1 2021, 3:36 PM
lld/test/wasm/lto/thinlto-thin-archive-collision.ll
3

Also, it may well be that there's simply no Windows build bots that run that test? Or that they use mingw or something else to circumvent the problem?

ormris removed a subscriber: ormris.Jan 24 2022, 11:29 AM
sbc100 removed a reviewer: sbc100.Mar 13 2022, 8:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2022, 8:43 AM
Herald added a subscriber: sbc100. · View Herald Transcript

Revision Contents

PathSize
lld/
test/
wasm/
lto/
2 lines

Diff 383895

lld/test/wasm/lto/thinlto-thin-archive-collision.ll

; Copied from lld/test/ELF/lto/thinlto-thin-archive-collision.ll ; Copied from lld/test/ELF/lto/thinlto-thin-archive-collision.ll
; UNSUPPORTED: system-windows
sbc100Unsubmitted
Not Done
ReplyInline Actions

Why doesn't this test run on windows? Can we fix it instead?

Why haven't others complained about this do you think?

sbc100: Why doesn't this test run on windows? Can we fix it instead? Why haven't others complained…
sbc100Unsubmitted
Not Done
ReplyInline Actions

This test was copied directly from lld/test/ELF/lto/thinlto-thin-archive-collision.ll .. which doesn't seem to be disabled on windows, so I wonder what is going on here that is different?

sbc100: This test was copied directly from `lld/test/ELF/lto/thinlto-thin-archive-collision.ll` ..
aardappelAuthorUnsubmitted
Done
ReplyInline Actions

It fails with

failed to open thinlto-archives/thin.aa/thin.o.0.preopt.bc: no such file or directory
failed to open thinlto-archives/thin.ab/thin.o.0.preopt.bc: no such file or directory

Is there maybe something about the script that is bash specific? It's running thru llvm-lit on powershell.

aardappel: It fails with ``` failed to open thinlto-archives/thin.aa/thin.o.0.preopt.bc: no such file or…
aardappelAuthorUnsubmitted
Done
ReplyInline Actions

Also, it may well be that there's simply no Windows build bots that run that test? Or that they use mingw or something else to circumvent the problem?

aardappel: Also, it may well be that there's simply no Windows build bots that run that test? Or that they…
; RUN: rm -fr %t && mkdir %t && cd %t ; RUN: rm -fr %t && mkdir %t && cd %t
; RUN: mkdir thinlto-archives thinlto-archives/a thinlto-archives/b ; RUN: mkdir thinlto-archives thinlto-archives/a thinlto-archives/b
; RUN: opt -thinlto-bc -o thinlto-archives/main.o %s ; RUN: opt -thinlto-bc -o thinlto-archives/main.o %s
; RUN: opt -thinlto-bc -o thinlto-archives/a/thin.o %S/Inputs/thin1.ll ; RUN: opt -thinlto-bc -o thinlto-archives/a/thin.o %S/Inputs/thin1.ll
; RUN: opt -thinlto-bc -o thinlto-archives/b/thin.o %S/Inputs/thin2.ll ; RUN: opt -thinlto-bc -o thinlto-archives/b/thin.o %S/Inputs/thin2.ll
; RUN: llvm-ar qcT thinlto-archives/thin.a thinlto-archives/a/thin.o thinlto-archives/b/thin.o ; RUN: llvm-ar qcT thinlto-archives/thin.a thinlto-archives/a/thin.o thinlto-archives/b/thin.o
; RUN: wasm-ld thinlto-archives/main.o thinlto-archives/thin.a -o thinlto-archives/main.exe --save-temps ; RUN: wasm-ld thinlto-archives/main.o thinlto-archives/thin.a -o thinlto-archives/main.exe --save-temps
; RUN: FileCheck %s < thinlto-archives/main.exe.resolution.txt ; RUN: FileCheck %s < thinlto-archives/main.exe.resolution.txt
Show All 18 Lines