We may want to restrict the detected platforms to only x86_64 and aarch64.
There are still custom detection in api.td but I don't think we can handle these:
- config/linux/api.td:205
- config/linux/api.td:199
Paths
| Differential D112818
[libc] Add more robust compile time architecture detection ClosedPublic Authored by gchatelet on Oct 29 2021, 7:44 AM.
Details Summary We may want to restrict the detected platforms to only x86_64 and aarch64.
Diff Detail
Event Timeline
Comment Actions Thanks for the nice cleanup.
This revision is now accepted and ready to land.Oct 29 2021, 10:44 AM
This revision was landed with ongoing or failed builds.Oct 29 2021, 1:15 PM Closed by commit rGa72e2499865b: [libc] Add more robust compile time architecture detection (authored by gchatelet). · Explain Why This revision was automatically updated to reflect the committed changes. gchatelet added a reverting change: rGfe953b15cf08: Revert "[libc] Add more robust compile time architecture detection".Oct 29 2021, 1:26 PM Comment Actions This patch broke the build so I've reverted it. I'll resubmit when it's fixed - and after the weekend :) This revision is now accepted and ready to land.Nov 2 2021, 3:20 AM Closed by commit rG0aea170b97f6: [libc] Add more robust compile time architecture detection (authored by gchatelet). · Explain WhyNov 2 2021, 4:01 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 383477 libc/src/__support/CMakeLists.txt
libc/src/__support/FPUtil/FEnvUtils.h
libc/src/__support/FPUtil/FMA.h
libc/src/__support/FPUtil/PlatformDefs.h
libc/src/__support/FPUtil/PolyEval.h
libc/src/__support/architectures.h
libc/src/string/memcmp.cpp
libc/src/string/memory_utils/elements_aarch64.h
libc/src/string/memory_utils/elements_x86.h
libc/src/string/memory_utils/memset_utils.h
libc/src/string/memory_utils/utils.h
libc/test/src/fenv/enabled_exceptions_test.cpp
libc/test/src/fenv/feenableexcept_test.cpp
libc/test/src/fenv/feholdexcept_test.cpp
libc/utils/MPFRWrapper/MPFRUtils.cpp
|
I don't think we actually support these architectures yet, do we need macros for them?