libc++ has had the guarantee of the default constructor of tuple<> being
trivial since 405570dc7a95cdf43cdee14b8a9f9c1657a6ad13. Now, the
standard mandates it as of LWG3211. So, move the file out of
libcxx/test/libcxx and into libcxx/test/std since it's no longer
libc++-specific. Rename it to be .compile.pass.cpp instead of
.pass.cpp while we're at it.
Details
Details
- Reviewers
ldionne • Quuxplusone Mordante - Group Reviewers
Restricted Project - Commits
- rG2d83392a8857: [libc++] Mark LWG3211 as complete: default constructor of tuple<> should be…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
One minor nit, other than that LGTM!
libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/empty_tuple_trivial.compile.pass.cpp | ||
---|---|---|
14 | Since it's compilation only main can be removed. |
libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/empty_tuple_trivial.compile.pass.cpp | ||
---|---|---|
14 | Good call. I plan on rebasing once CI is fixed/green and then if if this is still green after rebasing, I'll remove the main and land this. |
Since it's compilation only main can be removed.