This is an archive of the discontinued LLVM Phabricator instance.

Differential D112586

[lldb] Remove forgotten FIXME on CPlusPlus formatters
ClosedPublic

Authored by ljmf00 on Oct 26 2021, 5:42 PM.

Download Raw Diff

Details

Reviewers

teemperor

Commits

rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters

Summary

The patch [1] introduced this FIXME but ended up not being removed when fixed.

[1]: https://github.com/llvm/llvm-project/commit/f68df12fb039d5177e34f4541fa242b891949db6

Signed-off-by: Luís Ferreira <contact@lsferreira.net>

Diff Detail

Event Timeline

ljmf00 requested review of this revision.Oct 26 2021, 5:42 PM

ljmf00 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2021, 5:42 PM

Herald added a subscriber: lldb-commits. · View Herald Transcript

Harbormaster completed remote builds in B130835: Diff 382493.Oct 26 2021, 5:44 PM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptOct 26 2021, 5:44 PM

LGTM, thanks.

This revision is now accepted and ready to land.Oct 28 2021, 6:57 AM

In D112586#3093490, @teemperor wrote:

LGTM, thanks.

Note: I can't land it

In D112586#3094519, @ljmf00 wrote:

In D112586#3093490, @teemperor wrote:

LGTM, thanks.

Note: I can't land it

I can land it for you tomorrow (unless someone beats me to it :) )

Closed by commit rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters (authored by ljmf00, committed by teemperor). · Explain WhyOct 29 2021, 2:33 AM

This revision was automatically updated to reflect the committed changes.

teemperor added a commit: rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters.

Revision Contents

Path

Size

lldb/

source/

Plugins/

Language/

CPlusPlus/

CPlusPlusLanguage.cpp

2 lines

Diff 382493

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

Show First 20 Lines • Show All 1,004 Lines • ▼ Show 20 Lines	static void LoadSystemFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
string_array_flags.SetCascades(true)		string_array_flags.SetCascades(true)
.SetSkipPointers(true)		.SetSkipPointers(true)
.SetSkipReferences(false)		.SetSkipReferences(false)
.SetDontShowChildren(true)		.SetDontShowChildren(true)
.SetDontShowValue(true)		.SetDontShowValue(true)
.SetShowMembersOneLiner(false)		.SetShowMembersOneLiner(false)
.SetHideItemNames(false);		.SetHideItemNames(false);

// FIXME because of a bug in the FormattersContainer we need to add a summary
// for both X* and const X* (<rdar://problem/12717717>)
AddCXXSummary(		AddCXXSummary(
cpp_category_sp, lldb_private::formatters::Char8StringSummaryProvider,		cpp_category_sp, lldb_private::formatters::Char8StringSummaryProvider,
"char8_t * summary provider", ConstString("char8_t *"), string_flags);		"char8_t * summary provider", ConstString("char8_t *"), string_flags);
AddCXXSummary(cpp_category_sp,		AddCXXSummary(cpp_category_sp,
lldb_private::formatters::Char8StringSummaryProvider,		lldb_private::formatters::Char8StringSummaryProvider,
"char8_t [] summary provider",		"char8_t [] summary provider",
ConstString("char8_t ?\\[[0-9]+\\]"), string_array_flags, true);		ConstString("char8_t ?\\[[0-9]+\\]"), string_array_flags, true);

▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines