[Lex] Remove timer from #pragma clang __debug crash handler

[sammccall]

Summary

This seems to be temporary code for testing 28ad9fc20823678881baa0d723834b88ea9e8e3a
which was never removed

[aganea]

This Timer is actually the test coverage for that commit. If we don’t want it here, I guess you could move it to the Support unit tests?

[sammccall]

In D112498#3086029, @aganea wrote:

This Timer is actually the test coverage for that commit.

Ah, our issue is that it runs in production as well as in the tests. Each time the parser sees the crash pragma it dumps a bunch of output to stderr, even if the pragma is disabled in PP opts.

If we don’t want it here, I guess you could move it to the Support unit tests?

Makes sense. Do I understand right that we want to a crash recovery context, a timer region within it, and then abort() within that?
And we're just verifying we can do that a couple of times without crashing?

[aganea]

That sounds right. You can test that scenario in a debugger, by putting a breakpoint before BuryPointer in clang/tools/driver/driver.cpp and verifying that the TimerGroup still has a pointer to the deleted stack frames, after the CrashRecoveryContext has successfully catched the abort().

clang/lib/Lex/Pragma.cpp

 #include "llvm/ADT/Optional.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/ErrorHandling.h"
-#include "llvm/Support/Timer.h"
 #include <algorithm>
 #include <cassert>
 #include <cstddef>
 #include <cstdint>
 #include <limits>
 #include <string>
 #include <utility>
 #include <vector>
if (Tok.isNot(tok::identifier)) {
       return;
     }
     IdentifierInfo *II = Tok.getIdentifierInfo();
 
     if (II->isStr("assert")) {
       if (!PP.getPreprocessorOpts().DisablePragmaDebugCrash)
         llvm_unreachable("This is an assertion!");
     } else if (II->isStr("crash")) {
-      llvm::Timer T("crash", "pragma crash");
-      llvm::TimeRegion R(&T);
       if (!PP.getPreprocessorOpts().DisablePragmaDebugCrash)
         LLVM_BUILTIN_TRAP;
     } else if (II->isStr("parser_crash")) {
       if (!PP.getPreprocessorOpts().DisablePragmaDebugCrash) {
         Token Crasher;
         Crasher.startToken();
         Crasher.setKind(tok::annot_pragma_parser_crash);
         Crasher.setAnnotationRange(SourceRange(Tok.getLocation()));