This is an archive of the discontinued LLVM Phabricator instance.

Differential D112392

[lld-macho][nfc] Rename output binary so it doesn't overwrite existing one.
ClosedPublic

Authored by oontvoo on Oct 24 2021, 7:47 PM.

Details

Reviewers
gkm
int3
Group Reviewers
Restricted Project
Commits
rG7d549acbb69b: [lld-macho][nfc] Rename output binary so it doesn't overwrite existing one
Summary

%t/basics already exists - it would be nice to be able to examine it afterward

Diff Detail

Event Timeline

oontvoo created this revision.Oct 24 2021, 7:47 PM
Herald added a reviewer: gkm. · View Herald TranscriptOct 24 2021, 7:47 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
oontvoo requested review of this revision.Oct 24 2021, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2021, 7:47 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
oontvoo added a reviewer: int3.Oct 24 2021, 8:00 PM
Harbormaster completed remote builds in B130340: Diff 381822.Oct 24 2021, 8:02 PM
int3 accepted this revision.Oct 24 2021, 9:49 PM

thanks!

nit: no need for a period in the commit title

This revision is now accepted and ready to land.Oct 24 2021, 9:49 PM
oontvoo updated this revision to Diff 381976.Oct 25 2021, 6:56 AM

updated commit msg + rebase

oontvoo added a comment.Oct 25 2021, 6:56 AM

Thanks!

This revision was landed with ongoing or failed builds.Oct 25 2021, 6:57 AM
Closed by commit rG7d549acbb69b: [lld-macho][nfc] Rename output binary so it doesn't overwrite existing one (authored by oontvoo). · Explain Why
This revision was automatically updated to reflect the committed changes.
oontvoo added a commit: rG7d549acbb69b: [lld-macho][nfc] Rename output binary so it doesn't overwrite existing one.
Harbormaster completed remote builds in B130452: Diff 381976.Oct 25 2021, 7:37 AM

Revision Contents

PathSize
lld/
test/
MachO/
4 lines

Diff 381976

lld/test/MachO/dead-strip.s

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
# DYLIB-NEXT: l {{.*}} _ref_private_extern # DYLIB-NEXT: l {{.*}} _ref_private_extern
# DYLIB-NEXT: g {{.*}} _ref_com # DYLIB-NEXT: g {{.*}} _ref_com
# DYLIB-NEXT: g {{.*}} _unref_com # DYLIB-NEXT: g {{.*}} _unref_com
# DYLIB-NEXT: g {{.*}} _unref_extern # DYLIB-NEXT: g {{.*}} _unref_extern
# DYLIB-NEXT: g {{.*}} _no_dead_strip_globl # DYLIB-NEXT: g {{.*}} _no_dead_strip_globl
## Extern symbols aren't stripped from executables with -export_dynamic ## Extern symbols aren't stripped from executables with -export_dynamic
# RUN: %lld -lSystem -dead_strip -export_dynamic -u _ref_private_extern_u \ # RUN: %lld -lSystem -dead_strip -export_dynamic -u _ref_private_extern_u \
# RUN: %t/basics.o -o %t/basics # RUN: %t/basics.o -o %t/basics-export-dyn
# RUN: llvm-objdump --syms --section-headers %t/basics | \ # RUN: llvm-objdump --syms --section-headers %t/basics-export-dyn | \
# RUN: FileCheck --check-prefix=EXECDYN %s # RUN: FileCheck --check-prefix=EXECDYN %s
# EXECDYN-LABEL: Sections: # EXECDYN-LABEL: Sections:
# EXECDYN-LABEL: Name # EXECDYN-LABEL: Name
# EXECDYN-NEXT: __text # EXECDYN-NEXT: __text
# EXECDYN-NEXT: __got # EXECDYN-NEXT: __got
# EXECDYN-NEXT: __ref_section # EXECDYN-NEXT: __ref_section
# EXECDYN-NEXT: __common # EXECDYN-NEXT: __common
# EXECDYN-LABEL: SYMBOL TABLE: # EXECDYN-LABEL: SYMBOL TABLE:
▲ Show 20 Lines • Show All 753 Lines • Show Last 20 Lines