This is an archive of the discontinued LLVM Phabricator instance.

[LegalizeTypes][VE] Fix a regression test following previous cttz fix
AbandonedPublic

Authored by kaz7 on Oct 24 2021, 11:06 AM.

Details

Reviewers
simoll
k-ishizaka
Summary

An "Expand CTLZ/CTTZ/CTPOP instead of promoting if they'll be expanded
later" patch, 0766aef, also fixes a problem in the VE code generation.
Thank you! This patch updates .ll regression test.

Diff Detail

Event Timeline

kaz7 requested review of this revision.Oct 24 2021, 11:06 AM
kaz7 created this revision.
kaz7 abandoned this revision.Oct 26 2021, 2:21 AM

Identical fixes is already merged at bb5e358. Thanks!

craig.topper added inline comments.
llvm/test/CodeGen/VE/Scalar/cttz.ll
67

For my own education, what does (48)0 mean here?

efocht added a subscriber: efocht.Oct 26 2021, 12:51 PM
efocht added inline comments.
llvm/test/CodeGen/VE/Scalar/cttz.ll
67

That's a 64 bit immediate value with 48 zeros (from left) and (64-48) ones.

The NEC VE has two slightly odd types of immediate values: (m)0 and (m)1. The later consists of m ones (from left and (64-m) zeros.