This is an archive of the discontinued LLVM Phabricator instance.

Differential D112354

[NFC][X86] Add MC tests for all untested VIA PadLock instructions
ClosedPublic

Authored by jrtc27 on Oct 22 2021, 5:16 PM.

Details

Reviewers
craig.topper
Commits
rGb432583d28ee: [NFC][X86] Add MC tests for all untested VIA PadLock instructions
Summary

We currently only test the encoding of xstore but none of the other
instructions, which should all have their implicit REP prefix be
verified as working.

Diff Detail

Event Timeline

jrtc27 requested review of this revision.Oct 22 2021, 5:16 PM
jrtc27 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2021, 5:16 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
craig.topper added a comment.Oct 22 2021, 5:22 PM

Do we have a test for xstorerng alias?

jrtc27 added a comment.Oct 22 2021, 5:24 PM
In D112354#3081872, @craig.topper wrote:

Do we have a test for xstorerng alias?

No. We also don't seem to have tests for, nor even handle, the xstore-rng / xcrypt-ecb forms that seem to be the canonical forms GNU objdump prints.

jrtc27 added a child revision: D112355: [X86] Don't add implicit REP prefix to VIA PadLock xstore.Oct 22 2021, 5:24 PM

(Not that I really want to do that myself, I just saw the commit notification email for the FreeBSD workaround and figured I should fix LLVM)

joerg added a subscriber: joerg.Oct 22 2021, 5:30 PM

It should be noted that xstore is currently misassembled compared to GNU as.

craig.topper accepted this revision.Oct 22 2021, 5:31 PM

LGTM

This revision is now accepted and ready to land.Oct 22 2021, 5:31 PM
jrtc27 added a comment.Oct 22 2021, 5:31 PM
In D112354#3081890, @joerg wrote:

It should be noted that xstore is currently misassembled compared to GNU as.

Yes, that was the motivation for this; see the child revision :)

This revision was landed with ongoing or failed builds.Oct 22 2021, 5:57 PM
Closed by commit rGb432583d28ee: [NFC][X86] Add MC tests for all untested VIA PadLock instructions (authored by jrtc27). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGb432583d28ee: [NFC][X86] Add MC tests for all untested VIA PadLock instructions.
Harbormaster completed remote builds in B130230: Diff 381685.Oct 22 2021, 6:15 PM

Revision Contents

PathSize
llvm/
test/
MC/
X86/
24 lines

Diff 381690

llvm/test/MC/X86/padlock.s

// RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s // RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s
xstore xstore
// CHECK: xstore // CHECK: xstore
// CHECK: encoding: [0xf3,0x0f,0xa7,0xc0] // CHECK: encoding: [0xf3,0x0f,0xa7,0xc0]
xcryptecb
// CHECK: xcryptecb
// CHECK: encoding: [0xf3,0x0f,0xa7,0xc8]
xcryptcbc
// CHECK: xcryptcbc
// CHECK: encoding: [0xf3,0x0f,0xa7,0xd0]
xcryptctr
// CHECK: xcryptctr
// CHECK: encoding: [0xf3,0x0f,0xa7,0xd8]
xcryptcfb
// CHECK: xcryptcfb
// CHECK: encoding: [0xf3,0x0f,0xa7,0xe0]
xcryptofb
// CHECK: xcryptofb
// CHECK: encoding: [0xf3,0x0f,0xa7,0xe8]
xsha1
// CHECK: xsha1
// CHECK: encoding: [0xf3,0x0f,0xa6,0xc8]
xsha256
// CHECK: xsha256
// CHECK: encoding: [0xf3,0x0f,0xa6,0xd0]
montmul
// CHECK: montmul
// CHECK: encoding: [0xf3,0x0f,0xa6,0xc0]