[bazel] fixes for windows build

[ychen]

Summary

Giving Bazel a try on Win10 by following the README. It needs these fixes
to build through. Think that I should sent it out in case it is useful.

[GMNGeoffrey]

Thanks for upstreaming your fixes :-) It looks like this has some overlap with https://reviews.llvm.org/D112399 and https://reviews.llvm.org/D111930. Let's let those land and then see what's still necessary here

utils/bazel/llvm-project-overlay/clang/BUILD.bazel

1336

@chandlerc thoughts on this?

1805

I don't understand why we need this at all, actually :-/ Let me investigate

utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h

78

FYI, https://reviews.llvm.org/D112399 is also fixing this

utils/bazel/llvm-project-overlay/llvm/config.bzl

63

Just commenting these out isn't right. I believe you're likely hitting the same issue fixed in https://reviews.llvm.org/D112399 with macro redefines

[ychen]

utils/bazel/llvm-project-overlay/llvm/config.bzl

63

Thanks for the link. Yeah, I wasn't sure about this part.

[GMNGeoffrey]

If you'd like to rebase this and see what's still outstanding, I can take another look :-)

[ychen]

In D112353#3291381, @GMNGeoffrey wrote:

If you'd like to rebase this and see what's still outstanding, I can take another look :-)

Thanks for getting around to this. I rebased the patch and reran the build. It seems the newly added libc build causes many errors. It is vague about its windows support (https://releases.llvm.org/12.0.0/docs/Proposals/LLVMLibC.html#platform-support). Maybe it should be excluded by default for windows?

clang/unittests/libclang/TestUtils.h

if (!llvm::sys::path::is_absolute(Filename)) {
       llvm::SmallString<256> Path(TestDir);
       llvm::sys::path::append(Path, Filename);
       Filename = std::string(Path.str());
     }
     auto it = UnsavedFileContents.insert(std::make_pair(
         fixed_addr_string(new std::string(Filename)),
         fixed_addr_string(new std::string(Contents))));
     UnsavedFiles.push_back({
         it.first->first->c_str(),   // filename
         it.first->second->c_str(),  // contents
-        it.first->second->size()    // length
+        static_cast<unsigned long>(it.first->second->size())    // length
     });
   }
   template<typename F>
   void Traverse(const F &TraversalFunctor) {
     CXCursor TuCursor = clang_getTranslationUnitCursor(ClangTU);
     std::reference_wrapper<const F> FunctorRef = std::cref(TraversalFunctor);
     clang_visitChildren(TuCursor,
         &TraverseStateless<std::reference_wrapper<const F>>,
         &FunctorRef);
   }
 private:
   template<typename TState>
   static CXChildVisitResult TraverseStateless(CXCursor cx, CXCursor parent,
       CXClientData data) {
     TState *State = static_cast<TState*>(data);
     return State->get()(cx, parent);
   }
 };
 
-#endif // LLVM_CLANG_TEST_TESTUTILS_H
+#endif // LLVM_CLANG_TEST_TESTUTILS_H
 

utils/bazel/llvm-project-overlay/clang/BUILD.bazel

deps = [
         "//llvm:BinaryFormat",
         "//llvm:MC",
         "//llvm:Option",
         "//llvm:ProfileData",
         "//llvm:Support",
         "//llvm:Target",
         "//llvm:config",
     ],
+    linkopts = select({
+        "@bazel_tools//src/conditions:windows": ["/DEFAULTLIB:version.lib"],
+        "//conditions:default": [],
+    }),
 )
 
 gentbl(
     name = "headers_arm_neon_gen",
     tbl_outs = [(
         "-gen-arm-neon",
         "lib/Headers/arm_neon.h",
     )],

 
 cc_binary(
     name = "c-index-test",
     testonly = 1,
     srcs = [
         "tools/c-index-test/c-index-test.c",
         "tools/c-index-test/core_main.cpp",
     ],
-    copts = [
-        "-Wno-uninitialized",
-    ],
+    copts = select({
+        "@bazel_tools//src/conditions:windows": [],
+        "//conditions:default": ["-Wno-uninitialized"],
+    }),
     stamp = 0,
     deps = [
         ":ast",
         ":basic",
         ":c-bindings",
         ":codegen",
         ":config",
         ":frontend",

utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h

 
 /* Directory where gcc is installed. */
 #define GCC_INSTALL_PREFIX ""
 
 /* Define if we have libxml2 */
 /* #undef CLANG_HAVE_LIBXML */
 
 /* Define if we have sys/resource.h (rlimits) */
-#define CLANG_HAVE_RLIMITS 1
+/* #undef CLANG_HAVE_RLIMITS */
 
 /* The LLVM product name and version */
 #define BACKEND_PACKAGE_STRING "LLVM 12.0.0git"
 
 /* Linker version detected at compile time. */
 /* #undef HOST_LINK_VERSION */
 
 /* pass --build-id to ld */

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

deps = [
         ":Support",
     ],
 )
 
 cc_binary(
     name = "llvm-mca",
     srcs = glob([
         "tools/llvm-mca/*.cpp",
+        "tools/llvm-mca/*.h",
         "tools/llvm-mca/Views/*.cpp",
+        "tools/llvm-mca/Views/*.h",
     ]),
     copts = llvm_copts,
     stamp = 0,
     deps = [
         ":AllTargetsAsmParsers",
         ":AllTargetsCodeGens",
         ":AllTargetsDisassemblers",
         ":AllTargetsMCAs",

utils/bazel/llvm-project-overlay/llvm/config.bzl

posix_defines = [
     "LLVM_ON_UNIX=1",
     "HAVE_BACKTRACE=1",
     "BACKTRACE_HEADER=<execinfo.h>",
     r'LTDL_SHLIB_EXT=\".so\"',
     r'LLVM_PLUGIN_EXT=\".so\"',
     "LLVM_ENABLE_THREADS=1",
     "HAVE_SYSEXITS_H=1",
     "HAVE_UNISTD_H=1",
+    "HAVE_PTHREAD_H=1",
+    "HAVE_SYS_RESOURCE_H=1",
+    "CLANG_HAVE_RLIMITS=1",
+    "HAVE_SETENV=1",
     "HAVE_STRERROR_R=1",
     "HAVE_LIBPTHREAD=1",
     "HAVE_PTHREAD_GETNAME_NP=1",
     "HAVE_PTHREAD_SETNAME_NP=1",
     "HAVE_PTHREAD_GETSPECIFIC=1",
     "HAVE_REGISTER_FRAME=1",
     "HAVE_DEREGISTER_FRAME=1",
 ]
macos_defines = posix_defines + [
     "HAVE_MALLOC_MALLOC_H=1",
     "HAVE_MALLOC_ZONE_STATISTICS=1",
     "HAVE_PROC_PID_RUSAGE=1",
     "HAVE_UNW_ADD_DYNAMIC_FDE=1",
 ]
 
 win32_defines = [
     # MSVC specific
-    "stricmp=_stricmp",
-    "strdup=_strdup",
+    #"stricmp=_stricmp",
+    #"strdup=_strdup",
+    "CINDEX_NO_EXPORTS",
 
     # LLVM features
     r'LTDL_SHLIB_EXT=\".dll\"',
     r'LLVM_PLUGIN_EXT=\".dll\"',
 ]
 
 # TODO: We should switch to platforms-based config settings to make this easier
 # to express.

utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h

 
 /* Define to 1 if you have the `pread' function. */
 #define HAVE_PREAD 1
 
 /* Have pthread_getspecific */
 #define HAVE_PTHREAD_GETSPECIFIC 1
 
 /* Define to 1 if you have the <pthread.h> header file. */
-#define HAVE_PTHREAD_H 1
+/* HAVE_PTHREAD_H defined in Bazel */
 
 /* Have pthread_mutex_lock */
 #define HAVE_PTHREAD_MUTEX_LOCK 1
 
 /* Have pthread_rwlock_init */
 #define HAVE_PTHREAD_RWLOCK_INIT 1
 
 /* Define to 1 if you have the `sbrk' function. */
 /* HAVE_SBRK defined in Bazel */
 
 /* Define to 1 if you have the `setenv' function. */
-#define HAVE_SETENV 1
+/* HAVE_SETENV defined in Bazel */
 
 /* Define to 1 if you have the `setrlimit' function. */
 #define HAVE_SETRLIMIT 1
 
 /* Define to 1 if you have the `sigaltstack' function. */
 #define HAVE_SIGALTSTACK 1
 
 /* Define to 1 if you have the <signal.h> header file. */

 
 /* Define to 1 if you have the <sys/mman.h> header file. */
 #define HAVE_SYS_MMAN_H 1
 
 /* Define to 1 if you have the <sys/param.h> header file. */
 #define HAVE_SYS_PARAM_H 1
 
 /* Define to 1 if you have the <sys/resource.h> header file. */
-#define HAVE_SYS_RESOURCE_H 1
+/* HAVE_SYS_RESOURCE_H defined in Bazel */
 
 /* Define to 1 if you have the <sys/stat.h> header file. */
 #define HAVE_SYS_STAT_H 1
 
 /* Define to 1 if you have the <sys/time.h> header file. */
 #define HAVE_SYS_TIME_H 1
 
 /* Define to 1 if stat struct has st_mtimespec member .*/