This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Include revision numbers in the paper status lists
ClosedPublic

Authored by ldionne on Oct 22 2021, 12:11 PM.

Details

Summary

Several of our C++20 and C++2b papers were missing the actual revision
number that was voted in to the Standard. The revision number is quite
important because in a few cases, a paper has a revision *after* the
one that is voted into the Standard, which isn't voted into the Standard.
Hence, if we simply followed the wg21.link blindly and implemented that,
we'd end up implementing the latest revision of the paper, which might
not have been voted.

As a fly-by fix, I found out that P1664 had been withdrawn from the
straw polls and had never been voted into the Standard. This commit
removes that entry from our list.

Diff Detail

Event Timeline

ldionne requested review of this revision.Oct 22 2021, 12:11 PM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2021, 12:11 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 381625.Oct 22 2021, 12:12 PM
ldionne edited the summary of this revision. (Show Details)

Mention P1664 fly-by removal in the commit message.

var-const accepted this revision.Oct 22 2021, 12:39 PM
Quuxplusone added a subscriber: Quuxplusone.

I assume all these are the right revision numbers. ;) LGTM!

xgupta added a subscriber: xgupta.Oct 23 2021, 1:31 AM
xgupta added inline comments.
libcxx/docs/Status/Cxx20Papers.csv
205

It gives 404.

libcxx/docs/Status/Cxx2bPapers.csv
27

404

33

404

Mordante accepted this revision.Oct 23 2021, 5:00 AM

Thanks for fixing this! LGTM, but I prefer to wait until the October mailing is available to see whether the 3 papers @xgupta mentioned have been published. For these 3 versions it indeed seems that the versions listed are the versions voted.

libcxx/docs/Status/Cxx20Papers.csv
205

It seems this paper hasn't been published yet. Maybe wait to see whether it will be in the October mailing?

This revision is now accepted and ready to land.Oct 23 2021, 5:00 AM
ldionne added inline comments.Oct 25 2021, 7:54 AM
libcxx/docs/Status/Cxx20Papers.csv
205

I can definitely see it from here. Maybe because I'm logged in to isocpp.org. In all cases, I do think it will be publicly available soon, and when that happens this link will be correct.

Same for the other links below.

This revision was landed with ongoing or failed builds.Oct 25 2021, 7:55 AM
This revision was automatically updated to reflect the committed changes.