This is an archive of the discontinued LLVM Phabricator instance.

Fix printEscapedString: Hex escape is \xHH, not \HH.
AbandonedPublic

Authored by matthiaskramm on Oct 21 2021, 11:00 AM.

Details

Reviewers
Mogball

Diff Detail

Event Timeline

matthiaskramm created this revision.Oct 21 2021, 11:00 AM
matthiaskramm requested review of this revision.Oct 21 2021, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2021, 11:00 AM
Mogball added inline comments.Oct 21 2021, 11:56 AM
llvm/lib/Support/StringExtras.cpp
70

Can you add a test case for this?

Adjust test case.

matthiaskramm abandoned this revision.Oct 21 2021, 12:59 PM

Redoing this change, since (at least) MLIR uses \HH for hex escapes.