Page MenuHomePhabricator

[Polly][NFC] Switch createSubstitutions and createSubstitutionsVector to use isl::ast_expr
Needs ReviewPublic

Authored by InnovativeInventor on Oct 20 2021, 5:23 PM.

Details

Reviewers
Meinersbur
bollu
Summary

Polly is trying to reduce the amount of manual memory management and use isl::ast_expr, which implements RAII. This partially ports these two functions over to the preferred method of using isl.

Diff Detail

Event Timeline

InnovativeInventor requested review of this revision.Oct 20 2021, 5:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2021, 5:23 PM
Meinersbur added inline comments.Oct 20 2021, 8:09 PM
polly/lib/CodeGen/IslNodeBuilder.cpp
931
938
InnovativeInventor marked 2 inline comments as done.

Implemented some of Michael's suggestions.

Meinersbur added inline comments.Oct 25 2021, 8:59 AM
polly/lib/CodeGen/IslNodeBuilder.cpp
946

Did you consider converting IteratorID as well?