Page MenuHomePhabricator

InnovativeInventor (Max Fan)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Oct 7, 7:03 PM (1 w, 2 d)

Recent Activity

Yesterday

InnovativeInventor added a comment to D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.

LGTM.

Could you update the summary to something that makes sense in a commit message? Yes, you understand correctly.

Would you like me to land this patch for you?

Fri, Oct 15, 1:23 AM · Restricted Project, Restricted Project
InnovativeInventor updated the summary of D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.
Fri, Oct 15, 1:23 AM · Restricted Project, Restricted Project
InnovativeInventor updated the summary of D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.
Fri, Oct 15, 1:21 AM · Restricted Project, Restricted Project

Wed, Oct 13

InnovativeInventor added a comment to D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.

Fair point -- thanks for being so patient!

Wed, Oct 13, 8:49 PM · Restricted Project, Restricted Project
InnovativeInventor updated the diff for D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.

I ended up removing checkIslAstExprInt since it can be inlined.

Wed, Oct 13, 8:49 PM · Restricted Project, Restricted Project
InnovativeInventor added inline comments to D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.
Wed, Oct 13, 6:50 PM · Restricted Project, Restricted Project
InnovativeInventor updated the diff for D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.

Would be better to make this a function inside the ast_expr class? I could also overload the == operator for either ist::val or ist::ast_expr or both (not sure if this is a good idea though).

Wed, Oct 13, 6:48 PM · Restricted Project, Restricted Project
InnovativeInventor retitled D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr from [Polly] Switch checkIslAstExprInt to use RAII instead of manually freeing Expr to [Polly][NFC] Switch checkIslAstExprInt to use RAII instead of manually freeing Expr.
Wed, Oct 13, 6:43 PM · Restricted Project, Restricted Project
InnovativeInventor updated the diff for D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.
Wed, Oct 13, 5:28 PM · Restricted Project, Restricted Project
InnovativeInventor requested review of D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr.
Wed, Oct 13, 5:18 PM · Restricted Project, Restricted Project
InnovativeInventor accepted D111685: [Polly][NFC] Clean up Polly's getting started docs.

Yes, thanks!

Wed, Oct 13, 1:47 PM · Restricted Project, Restricted Project
InnovativeInventor updated the diff for D111685: [Polly][NFC] Clean up Polly's getting started docs.

I added a proper diff (I think) and added back the mistakenly removed menu that I didn't intend to commit.

Wed, Oct 13, 12:39 PM · Restricted Project, Restricted Project

Tue, Oct 12

InnovativeInventor added inline comments to D111685: [Polly][NFC] Clean up Polly's getting started docs.
Tue, Oct 12, 6:30 PM · Restricted Project, Restricted Project
InnovativeInventor updated the diff for D111685: [Polly][NFC] Clean up Polly's getting started docs.

Add Polly invocation instructions and resolve cmake/ninja confusion

Tue, Oct 12, 6:29 PM · Restricted Project, Restricted Project
InnovativeInventor retitled D111685: [Polly][NFC] Clean up Polly's getting started docs from [polly][NFC] Clean up Polly's getting started docs to [Polly][NFC] Clean up Polly's getting started docs.
Tue, Oct 12, 4:10 PM · Restricted Project, Restricted Project
InnovativeInventor added a project to D111685: [Polly][NFC] Clean up Polly's getting started docs: Restricted Project.
Tue, Oct 12, 4:09 PM · Restricted Project, Restricted Project
InnovativeInventor requested review of D111685: [Polly][NFC] Clean up Polly's getting started docs.
Tue, Oct 12, 4:07 PM · Restricted Project, Restricted Project