This is an archive of the discontinued LLVM Phabricator instance.

Enable libc++ in the build for libcxx initializerlist pretty printers
ClosedPublic

Authored by dblaikie on Oct 20 2021, 11:09 AM.

Diff Detail

Event Timeline

dblaikie requested review of this revision.Oct 20 2021, 11:09 AM
dblaikie created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2021, 11:09 AM

Looks like this test, when it was introduced/substantially refactored in D9426 - what was missing compared to all the other tests updated to run on linux, was the Makefile change to use libc++, so it was failing in places where libc++ wasn't the default. Fix that and it seems to pass for me, at least. Not sure if we need to keep some of the other expected failures (on some particular subset of clang, etc?)

Also there's a few other of these pretty printer tests that are still classified as skip-on-gcc, though at least some have been reclassified as passing-on-gcc in changes since D9426.

teemperor accepted this revision.Oct 21 2021, 12:29 AM

LGTM, thanks!

Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I would just see if any matrix bot complains and then re-apply it with a proper minimum required version.

This revision is now accepted and ready to land.Oct 21 2021, 12:29 AM

LGTM, thanks!

Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I would just see if any matrix bot complains and then re-apply it with a proper minimum required version.

"matrix bot"? One of the buildbots/group of them?

LGTM, thanks!

Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I would just see if any matrix bot complains and then re-apply it with a proper minimum required version.

"matrix bot"? One of the buildbots/group of them?

It's a single bot that runs the test suite against a variety of compilers (well, only various versions of clang, I think)...