We had two sets of build<flavour> methods, whose bodies were largely
identical. This makes any kind of modification in their vicinity
repetitive and error-prone.
Replace each set with a single method taking an optional debug_info
parameter.
Paths
| Differential D111989
[lldb] Reduce code duplication around inferior building ClosedPublic Authored by labath on Oct 18 2021, 5:49 AM.
Details Summary We had two sets of build<flavour> methods, whose bodies were largely Replace each set with a single method taking an optional debug_info
Diff Detail
Event Timelinelabath added a child revision: D111990: [lldb/test] Remove quote/unquote steps from the make invocations.Oct 18 2021, 6:17 AM Comment Actions Adjust for TestStandardUnwind removal (the patch fixes it sufficiently to make it litter the source tree with build artifacts). This revision is now accepted and ready to land.Oct 19 2021, 1:21 AM Closed by commit rG8bac18be0e45: [lldb] Reduce code duplication around inferior building (authored by labath). · Explain WhyOct 19 2021, 3:09 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 380372 lldb/docs/testsuite/a-detailed-walkthrough.txt
lldb/packages/Python/lldbsuite/test/README-TestSuite
lldb/packages/Python/lldbsuite/test/builders/builder.py
lldb/packages/Python/lldbsuite/test/builders/darwin.py
lldb/packages/Python/lldbsuite/test/lldbtest.py
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py
lldb/test/API/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
lldb/test/API/macosx/add-dsym/TestAddDsymDownload.py
lldb/test/API/macosx/add-dsym/TestAddDsymMidExecutionCommand.py
|