Page MenuHomePhabricator

[lldb] Reduce code duplication around inferior building
ClosedPublic

Authored by labath on Oct 18 2021, 5:49 AM.

Details

Summary

We had two sets of build<flavour> methods, whose bodies were largely
identical. This makes any kind of modification in their vicinity
repetitive and error-prone.

Replace each set with a single method taking an optional debug_info
parameter.

Diff Detail

Event Timeline

labath requested review of this revision.Oct 18 2021, 5:49 AM
labath created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 5:49 AM
labath updated this revision to Diff 380372.Oct 18 2021, 6:40 AM

Adjust for TestStandardUnwind removal (the patch fixes it sufficiently to make it litter the source tree with build artifacts).

teemperor accepted this revision.Oct 19 2021, 1:21 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 19 2021, 1:21 AM
This revision was automatically updated to reflect the committed changes.