This is an archive of the discontinued LLVM Phabricator instance.

[libc++] LWG3266: delete the to_chars(bool) overload.
ClosedPublic

Authored by var-const on Oct 14 2021, 3:08 PM.

Details

Summary

This PR only updates the synopsis in <charconv> -- the current
implementation already deletes
the overload and has a test
for it (and this has been the case from the first commit
where <charconv> was added).

Diff Detail

Event Timeline

var-const requested review of this revision.Oct 14 2021, 3:08 PM
var-const created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2021, 3:08 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

(Not sure on the best way to format links in the description. I tried avoiding overly long lines in the markdown, except where necessary, but now I see it looks weird in the UI)

Should I also update libcxx/docs/Status/Cxx20Issues.csv? Also, are there any other release notes/etc. where this might need to be mentioned? (I presume probably not, since it's such a small change, but just in case)

Should I also update libcxx/docs/Status/Cxx20Issues.csv?

Yes please. I believe the appropriate diff is

"`3266 <https://wg21.link/LWG3266>`__","``to_chars(bool)``\  should be deleted","Belfast","|Complete|","14.0"

LGTM otherwise. Please update the diff with Cxx20Issues.csv and then wait for @ldionne and/or @Mordante to approve it before landing it. Also, if you need someone else to land it, this would be a good time to say so, and to give your preferred name and email address for the commit message.

var-const updated this revision to Diff 379877.Oct 14 2021, 4:30 PM

Update the status CSV file.

Thanks a lot for the very fast review! I have applied your suggestion.

Yes, I would need somebody else to land this, please.
Name: Konstantin Varlamov
Email: varconst@apple.com

Mordante accepted this revision.Oct 15 2021, 8:44 AM

LGTM, thanks for adding the links to the implementation and tests.
I'll land it on your behalf.

This revision is now accepted and ready to land.Oct 15 2021, 8:44 AM
This revision was automatically updated to reflect the committed changes.