[libc++] LWG3266: delete the to_chars(bool) overload.

[var-const]

Summary

This PR only updates the synopsis in <charconv> -- the current
implementation already deletes
the overload and has a test
for it (and this has been the case from the first commit
where <charconv> was added).

[var-const]

(Not sure on the best way to format links in the description. I tried avoiding overly long lines in the markdown, except where necessary, but now I see it looks weird in the UI)

[var-const]

Should I also update libcxx/docs/Status/Cxx20Issues.csv? Also, are there any other release notes/etc. where this might need to be mentioned? (I presume probably not, since it's such a small change, but just in case)

[• Quuxplusone]

Should I also update libcxx/docs/Status/Cxx20Issues.csv?

Yes please. I believe the appropriate diff is

"`3266 <https://wg21.link/LWG3266>`__","``to_chars(bool)``\  should be deleted","Belfast","|Complete|","14.0"

LGTM otherwise. Please update the diff with Cxx20Issues.csv and then wait for @ldionne and/or @Mordante to approve it before landing it. Also, if you need someone else to land it, this would be a good time to say so, and to give your preferred name and email address for the commit message.

[var-const]

Update the status CSV file.

[var-const]

Thanks a lot for the very fast review! I have applied your suggestion.

Yes, I would need somebody else to land this, please.
Name: Konstantin Varlamov
Email: [e-mail]

[Mordante]

LGTM, thanks for adding the links to the implementation and tests.
I'll land it on your behalf.

libcxx/docs/Status/Cxx20Issues.csv

 "`3253 <https://wg21.link/LWG3253>`__","``basic_syncbuf::basic_syncbuf()``\  should not be explicit","Belfast","",""
 "`3245 <https://wg21.link/LWG3245>`__","Unnecessary restriction on ``'%p'``\  parse specifier","Belfast","",""
 "`3244 <https://wg21.link/LWG3244>`__","Constraints for ``Source``\  in |sect|\ [fs.path.req] insufficiently constrainty","Belfast","",""
 "`3241 <https://wg21.link/LWG3241>`__","``chrono-spec``\  grammar ambiguity in |sect|\ [time.format]","Belfast","",""
 "`3257 <https://wg21.link/LWG3257>`__","Missing feature testing macro update from P0858","Belfast","",""
 "`3256 <https://wg21.link/LWG3256>`__","Feature testing macro for ``constexpr``\  algorithms","Belfast","|Complete|","13.0"
 "`3273 <https://wg21.link/LWG3273>`__","Specify ``weekday_indexed``\  to range of ``[0, 7]``\ ","Belfast","",""
 "`3070 <https://wg21.link/LWG3070>`__","``path::lexically_relative``\  causes surprising results if a filename can also be a  *root-name*","Belfast","",""
-"`3266 <https://wg21.link/LWG3266>`__","``to_chars(bool)``\  should be deleted","Belfast","",""
+"`3266 <https://wg21.link/LWG3266>`__","``to_chars(bool)``\  should be deleted","Belfast","|Complete|","14.0"
 "`3272 <https://wg21.link/LWG3272>`__","``%I%p``\  should parse/format ``duration``\  since midnight","Belfast","",""
 "`3259 <https://wg21.link/LWG3259>`__","The definition of *constexpr iterators* should be adjusted","Belfast","",""
 "`3103 <https://wg21.link/LWG3103>`__","Errors in taking subview of ``span``\  should be ill-formed where possible","Belfast","",""
 "`3274 <https://wg21.link/LWG3274>`__","Missing feature test macro for ``<span>``\ ","Belfast","",""
 "`3276 <https://wg21.link/LWG3276>`__","Class ``split_view::outer_iterator::value_type``\  should inherit from ``view_interface``\ ","Belfast","",""
 "`3277 <https://wg21.link/LWG3277>`__","Pre-increment on prvalues is not a requirement of ``weakly_incrementable``\ ","Belfast","",""
 "`3149 <https://wg21.link/LWG3149>`__","``DefaultConstructible``\  should require default initialization","Belfast","|Complete|","13.0"
 "","","","",""

libcxx/include/charconv

namespace std {
   // 23.20.2, primitive numerical output conversion
   struct to_chars_result {
     char* ptr;
     errc ec;
   };
 
   to_chars_result to_chars(char* first, char* last, see below value,
                            int base = 10);
+  to_chars_result to_chars(char* first, char* last, bool value,
+                           int base = 10) = delete;
 
   to_chars_result to_chars(char* first, char* last, float value);
   to_chars_result to_chars(char* first, char* last, double value);
   to_chars_result to_chars(char* first, char* last, long double value);
 
   to_chars_result to_chars(char* first, char* last, float value,
                            chars_format fmt);
   to_chars_result to_chars(char* first, char* last, double value,