Page MenuHomePhabricator

[sanitizer] Remove tag from StackDepotNode
AcceptedPublic

Authored by vitalybuka on Tue, Oct 12, 12:07 AM.

Details

Reviewers
eugenis
dvyukov
Summary

And share storage with size.

Depends on D111615.

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Tue, Oct 12, 12:07 AM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Oct 12, 12:07 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Remove size from StackDepotNode

s/size/tag/?

But this does not reduce size of the node, it's still 16 bytes. So what's the point?

3 of https://reviews.llvm.org/D111614#3058999
plus it a part of StackTrace::tag so maybe more consistent to keep with the rest of trace, e.g. sharing word with StackTrace::size

vitalybuka retitled this revision from [sanitizer] Remove size from StackDepotNode to [sanitizer] Remove tag from StackDepotNode.Tue, Oct 12, 10:04 AM
vitalybuka edited the summary of this revision. (Show Details)

Remove size from StackDepotNode

s/size/tag/?

done

Also I am not convinced that we need the tag at all, but @eugenis has a different opinion D110880

dvyukov accepted this revision.Thu, Oct 14, 5:31 AM
This revision is now accepted and ready to land.Thu, Oct 14, 5:31 AM