This is an archive of the discontinued LLVM Phabricator instance.

[msan] Remove StackTrace::tag
Changes PlannedPublic

Authored by vitalybuka on Sep 30 2021, 1:39 PM.

Details

Reviewers
eugenis
Summary

The current implementation makes all sanitizers to track this value,
however even for msan this information constructed from this tag is
redundant and obvious from the stack itself.

There is simple way to implement this msan-only, but I does not look useful.

Event Timeline

vitalybuka requested review of this revision.Sep 30 2021, 1:39 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:39 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Hmm, I really like this info.

As a data point, we had user feedback that bug classification in hwasan (use-after-free vs overflow vs other kinds) is very useful even though it is pretty obvious if you think about how tags work - but that's extra work for the users, and requires better understanding of the tool.

Hmm, I really like this info.

As a data point, we had user feedback that bug classification in hwasan (use-after-free vs overflow vs other kinds) is very useful even though it is pretty obvious if you think about how tags work - but that's extra work for the users, and requires better understanding of the tool.

Tags are more complicated, but when stack has malloc() frame it's very obvious, up to the point that reporting code can print this parsing the stack.

missing tests

documentation

Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka planned changes to this revision.May 24 2023, 5:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 5:26 PM
Herald added a subscriber: Enna1. · View Herald Transcript