This is an archive of the discontinued LLVM Phabricator instance.

Differential D111501

[libc++][docs] Mark LWG3447 as complete
ClosedPublic

Authored by jloser on Oct 9 2021, 7:46 PM.

Details

Reviewers
ldionne
• Quuxplusone
Mordante
Group Reviewers
Restricted Project
Commits
rGe889099986bc: [libc++][docs] Mark LWG3447 as complete
Summary

Mark LWG3447 as complete since it was not an issue since the original
implementation of take_view from
0f4b41e038537ab2ab6fa2aa048e55c28a03ab68. Currently, take_view's
deduction guide does not constrain the range on the range concept.

Diff Detail

Event Timeline

jloser requested review of this revision.Oct 9 2021, 7:46 PM
jloser created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2021, 7:46 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante accepted this revision as: Mordante.Oct 10 2021, 5:26 AM

LGTM!

Harbormaster completed remote builds in B127967: Diff 378484.Oct 10 2021, 11:38 AM
ldionne accepted this revision.Oct 11 2021, 12:11 PM

LGTM but please look at my comment! Thanks for investigating :)

libcxx/docs/Status/Cxx2bIssues.csv
11

This should say 14.0 here cause we did not enable ranges in 13.0 (it was incomplete).

This revision is now accepted and ready to land.Oct 11 2021, 12:11 PM
Closed by commit rGe889099986bc: [libc++][docs] Mark LWG3447 as complete (authored by • joe_loser). · Explain WhyOct 11 2021, 6:41 PM
This revision was automatically updated to reflect the committed changes.
• joe_loser added a commit: rGe889099986bc: [libc++][docs] Mark LWG3447 as complete.
jloser added a comment.Oct 11 2021, 6:41 PM
In D111501#3055991, @ldionne wrote:

LGTM but please look at my comment! Thanks for investigating :)

Fixed and landed. Thanks for the reminder this should be marked with 14.0 and not 13.0.

Revision Contents

PathSize
libcxx/
docs/
Status/
2 lines

Diff 378848

libcxx/docs/Status/Cxx2bIssues.csv

"Issue #","Issue Name","Meeting","Status","First released version" "Issue #","Issue Name","Meeting","Status","First released version"
"`2839 <https://wg21.link/LWG2839>`__","Self-move-assignment of library types, again","November 2020","","" "`2839 <https://wg21.link/LWG2839>`__","Self-move-assignment of library types, again","November 2020","",""
"`3117 <https://wg21.link/LWG3117>`__","Missing ``packaged_task`` deduction guides","November 2020","","" "`3117 <https://wg21.link/LWG3117>`__","Missing ``packaged_task`` deduction guides","November 2020","",""
"`3143 <https://wg21.link/LWG3143>`__","``monotonic_buffer_resource`` growth policy is unclear","November 2020","","" "`3143 <https://wg21.link/LWG3143>`__","``monotonic_buffer_resource`` growth policy is unclear","November 2020","",""
"`3195 <https://wg21.link/LWG3195>`__","What is the stored pointer value of an empty weak_ptr?","November 2020","","" "`3195 <https://wg21.link/LWG3195>`__","What is the stored pointer value of an empty weak_ptr?","November 2020","",""
"`3211 <https://wg21.link/LWG3211>`__","``std::tuple<>`` should be trivially constructible","November 2020","","" "`3211 <https://wg21.link/LWG3211>`__","``std::tuple<>`` should be trivially constructible","November 2020","",""
"`3236 <https://wg21.link/LWG3236>`__","Random access iterator requirements lack limiting relational operators domain to comparing those from the same range","November 2020","","" "`3236 <https://wg21.link/LWG3236>`__","Random access iterator requirements lack limiting relational operators domain to comparing those from the same range","November 2020","",""
"`3265 <https://wg21.link/LWG3265>`__","``move_iterator``'s conversions are more broken after P1207","November 2020","Fixed by `LWG3435 <https://wg21.link/LWG3435>`__","" "`3265 <https://wg21.link/LWG3265>`__","``move_iterator``'s conversions are more broken after P1207","November 2020","Fixed by `LWG3435 <https://wg21.link/LWG3435>`__",""
"`3435 <https://wg21.link/LWG3435>`__","``three_way_comparable_with<reverse_iterator<int*>, reverse_iterator<const int*>>``","November 2020","|Complete|","13.0" "`3435 <https://wg21.link/LWG3435>`__","``three_way_comparable_with<reverse_iterator<int*>, reverse_iterator<const int*>>``","November 2020","|Complete|","13.0"
"`3432 <https://wg21.link/LWG3432>`__","Missing requirement for comparison_category","November 2020","","" "`3432 <https://wg21.link/LWG3432>`__","Missing requirement for comparison_category","November 2020","",""
"`3447 <https://wg21.link/LWG3447>`__","Deduction guides for ``take_view`` and ``drop_view`` have different constraints","November 2020","","" "`3447 <https://wg21.link/LWG3447>`__","Deduction guides for ``take_view`` and ``drop_view`` have different constraints","November 2020","|Complete|","14.0"
ldionneUnsubmitted
Not Done
ReplyInline Actions

This should say 14.0 here cause we did not enable ranges in 13.0 (it was incomplete).

ldionne: This should say `14.0` here cause we did not enable ranges in 13.0 (it was incomplete).
"`3450 <https://wg21.link/LWG3450>`__","The const overloads of ``take_while_view::begin/end`` are underconstrained","November 2020","","" "`3450 <https://wg21.link/LWG3450>`__","The const overloads of ``take_while_view::begin/end`` are underconstrained","November 2020","",""
"`3464 <https://wg21.link/LWG3464>`__","``istream::gcount()`` can overflow","November 2020","","" "`3464 <https://wg21.link/LWG3464>`__","``istream::gcount()`` can overflow","November 2020","",""
"`2731 <https://wg21.link/LWG2731>`__","Existence of ``lock_guard<MutexTypes...>::mutex_type`` typedef unclear","November 2020","","" "`2731 <https://wg21.link/LWG2731>`__","Existence of ``lock_guard<MutexTypes...>::mutex_type`` typedef unclear","November 2020","",""
"`2743 <https://wg21.link/LWG2743>`__","P0083R3 ``node_handle`` private members missing ""exposition only"" comment","November 2020","","" "`2743 <https://wg21.link/LWG2743>`__","P0083R3 ``node_handle`` private members missing ""exposition only"" comment","November 2020","",""
"`2820 <https://wg21.link/LWG2820>`__","Clarify ``<cstdint>`` macros","November 2020","","" "`2820 <https://wg21.link/LWG2820>`__","Clarify ``<cstdint>`` macros","November 2020","",""
"`3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","November 2020","","" "`3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","November 2020","",""
"`3170 <https://wg21.link/LWG3170>`__","``is_always_equal`` added to ``std::allocator`` makes the standard library treat derived types as always equal","November 2020","","" "`3170 <https://wg21.link/LWG3170>`__","``is_always_equal`` added to ``std::allocator`` makes the standard library treat derived types as always equal","November 2020","",""
"`3036 <https://wg21.link/LWG3036>`__","``polymorphic_allocator::destroy`` is extraneous","November 2020","","" "`3036 <https://wg21.link/LWG3036>`__","``polymorphic_allocator::destroy`` is extraneous","November 2020","",""
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines