Page MenuHomePhabricator

Workaround build error for mingw-g++
ClosedPublic

Authored by ldrumm on Oct 7 2021, 8:06 AM.

Details

Summary

Workaround build error for mingw-g++

mingw-g++ does not correctly support the full std::errc namespace as
worded in the standard[1]. As such, we cannot reliably use all names
therein. This patch changes the use of
std::errc::state_not_recoverable, to use portable error codes from the
portable llvm::errc equivalent.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71444

Diff Detail

Event Timeline

ldrumm created this revision.Oct 7 2021, 8:06 AM
ldrumm requested review of this revision.Oct 7 2021, 8:06 AM
ldrumm updated this revision to Diff 377864.Oct 7 2021, 8:21 AM

Can you map state_not_recoverable to not_supported?

Can you map state_not_recoverable to not_supported?

Sure. I wasn't really sure that the io_error and not_enough_memory were appropriate. Thanks for the confirmation

ldrumm updated this revision to Diff 377905.Oct 7 2021, 10:31 AM
v.g.vassilev accepted this revision.Oct 7 2021, 10:32 AM

Thanks for the patch!

This revision is now accepted and ready to land.Oct 7 2021, 10:32 AM
This revision was landed with ongoing or failed builds.Oct 7 2021, 10:36 AM
This revision was automatically updated to reflect the committed changes.