This is an archive of the discontinued LLVM Phabricator instance.

Differential D111235

[libcxx][CI] Install all locales used by the test suite
ClosedPublic

Authored by DavidSpickett on Oct 6 2021, 8:09 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGda5937654691: [libcxx][CI] Install all locales used by the test suite

Diff Detail

Event Timeline

DavidSpickett created this revision.Oct 6 2021, 8:09 AM
Herald added a subscriber: arichardson. · View Herald TranscriptOct 6 2021, 8:09 AM
DavidSpickett requested review of this revision.Oct 6 2021, 8:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2021, 8:09 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B127305: Diff 377553.Oct 6 2021, 8:09 AM
DavidSpickett added a reviewer: ldionne.Oct 6 2021, 8:10 AM

I've tested this locally and none of the newly enabled tests are failing.

Side note: I would use "echo -e" here but for some reason the "-e" ends up in the file. printf works fine in any case.

DavidSpickett mentioned this in D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests.Oct 6 2021, 8:11 AM
ldionne accepted this revision.Oct 6 2021, 8:28 AM
ldionne added inline comments.
libcxx/utils/ci/Dockerfile
47

Please insert a newline between 47 and 46.

This revision is now accepted and ready to land.Oct 6 2021, 8:28 AM
This revision was landed with ongoing or failed builds.Oct 7 2021, 1:24 AM
Closed by commit rGda5937654691: [libcxx][CI] Install all locales used by the test suite (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rGda5937654691: [libcxx][CI] Install all locales used by the test suite.

Revision Contents

PathSize
libcxx/
utils/
ci/
8 lines

Diff 377553

libcxx/utils/ci/Dockerfile

Show All 38 Lines
# Docker image forever. # Docker image forever.
RUN echo 1 RUN echo 1
RUN apt-get update && apt-get install -y bash curl RUN apt-get update && apt-get install -y bash curl
# Install various tools used by the build or the test suite # Install various tools used by the build or the test suite
RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils git gdb RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils git gdb
RUN apt-get update && apt-get install -y libc6-dev-i386 # Required to cross-compile to 32 bits RUN apt-get update && apt-get install -y libc6-dev-i386 # Required to cross-compile to 32 bits
# Locales for gdb and localization tests
ldionneUnsubmitted
Not Done
ReplyInline Actions

Please insert a newline between 47 and 46.

ldionne: Please insert a newline between 47 and 46.
RUN apt-get update && apt-get install -y language-pack-en language-pack-fr \
language-pack-ru language-pack-zh-hans
# These two are not enabled by default so generate them
RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /etc/locale.gen
RUN mkdir /usr/local/share/i1en/
RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /usr/local/share/i1en/SUPPORTED
RUN locale-gen
# Install Clang <latest>, <latest-1> and ToT, which are the ones we support. # Install Clang <latest>, <latest-1> and ToT, which are the ones we support.
ENV LLVM_LATEST_VERSION=12 ENV LLVM_LATEST_VERSION=12
RUN apt-get update && apt-get install -y lsb-release wget software-properties-common RUN apt-get update && apt-get install -y lsb-release wget software-properties-common
RUN wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh RUN wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh
RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 1)) # previous release RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 1)) # previous release
RUN bash /tmp/llvm.sh $LLVM_LATEST_VERSION # latest release RUN bash /tmp/llvm.sh $LLVM_LATEST_VERSION # latest release
RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION + 1)) # current ToT RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION + 1)) # current ToT
Show All 36 Lines