Details
Details
- Reviewers
morehouse eugenis - Commits
- rGdc603b0e5305: [NFC][sanitizer] Add basic hash test
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I'm not sure what does this test test.
Do we depend anywhere on the hash function producing these exact values, or is it part of an abi contract?
Comment Actions
Almost all out unittest are not about contract or ABI, for that we usually use lit tests.
This is regression tests, if it fail, we have a problem.
compiler-rt/lib/sanitizer_common/tests/sanitizer_hash_test.cpp | ||
---|---|---|
10 | Maybe explain here that these are regression tests to ensure consistent hash results and that we don't unintentionally change the hash algorithm. |
Maybe explain here that these are regression tests to ensure consistent hash results and that we don't unintentionally change the hash algorithm.